Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Issue 341533004: Do not update libaddressinput strings on 'gclient runhooks'. (Closed)

Created:
6 years, 6 months ago by please use gerrit instead
Modified:
6 years, 6 months ago
Reviewers:
Lei Zhang, Evan Stade
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Do not update libaddressinput strings on 'gclient runhooks'. This patch stops updating chrome/app/address_input_strings.grdp when running 'gclient runhooks'. This is necessary to enable checking in a static version of chrome/app/address_input_strings.grdp. https://codereview.chromium.org/337163002/ needs this patch to land. BUG=327046 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278036

Patch Set 1 #

Patch Set 2 : No repacking. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -37 lines) Patch
M .gitignore View 1 chunk +0 lines, -1 line 0 comments Download
M DEPS View 1 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/tools/build/repack_locales.py View 1 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/libaddressinput/libaddressinput.gyp View 2 chunks +0 lines, -22 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
please use gerrit instead
FYI
6 years, 6 months ago (2014-06-17 17:33:56 UTC) #1
please use gerrit instead
The CQ bit was checked by rouslan@chromium.org
6 years, 6 months ago (2014-06-17 17:34:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rouslan@chromium.org/341533004/1
6 years, 6 months ago (2014-06-17 17:35:51 UTC) #3
please use gerrit instead
The CQ bit was unchecked by rouslan@chromium.org
6 years, 6 months ago (2014-06-17 19:39:45 UTC) #4
Evan Stade
lgtm
6 years, 6 months ago (2014-06-17 23:21:03 UTC) #5
please use gerrit instead
Lei: OWNERS PTAL Patch Set 2: - chrome/tools/build/repack_locales.py
6 years, 6 months ago (2014-06-17 23:25:42 UTC) #6
Lei Zhang
lgtm
6 years, 6 months ago (2014-06-17 23:27:47 UTC) #7
please use gerrit instead
The CQ bit was checked by rouslan@chromium.org
6 years, 6 months ago (2014-06-17 23:29:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rouslan@chromium.org/341533004/20001
6 years, 6 months ago (2014-06-17 23:30:26 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-18 11:46:53 UTC) #10
Message was sent while issue was closed.
Change committed as 278036

Powered by Google App Engine
This is Rietveld 408576698