Resolve percent lengths for abs. positioned tables against padding box.

Resolve percent lengths for abs. positioned tables against padding box.

According to CSS2.1: "[...] absolutely positioned elements whose
containing block is based on a block container element, the percentage
is calculated with respect to the width of the padding box of that
element".

BUG=366123
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177101

[Julien - ping for review, 2014-06-17 20:57:43]

https://codereview.chromium.org/341523002/diff/1/LayoutTests/fast/table/absol...
File LayoutTests/fast/table/absolute-table-percent-lengths-expected.html
(right):

https://codereview.chromium.org/341523002/diff/1/LayoutTests/fast/table/absol...
LayoutTests/fast/table/absolute-table-percent-lengths-expected.html:9: float:
left;
Do we really need some relative float?

https://codereview.chromium.org/341523002/diff/1/LayoutTests/fast/table/absol...
LayoutTests/fast/table/absolute-table-percent-lengths-expected.html:24:
div:nth-child(4) span.tbl { left: 0; bottom: 0; }
I prefer to use simple selectors (class, id) when not required by the test. It
makes the test more resilient (less selector code to run), more readable as it
gives names to applied style too.

https://codereview.chromium.org/341523002/diff/1/LayoutTests/fast/table/absol...
File LayoutTests/fast/table/absolute-table-percent-lengths.html (right):

https://codereview.chromium.org/341523002/diff/1/LayoutTests/fast/table/absol...
LayoutTests/fast/table/absolute-table-percent-lengths.html:49: <div><span
class="tbl"><span class="cell">abc</span></span></div>
This test would probably be better as a check-layout.js test for several
reasons:
- the expected result would be trivial (you should see only PASS)
- the test would be faster (we don't need to render 2 tests and compare the
pixel results)
- it makes the test more reliant to shooting yourself in the foot (as we only
compare pixel results, any viewport overflow is untested).

That said, it's a nit (unless it's the reason we need all this style extras).

[andersr, 2014-06-18 05:42:40]

Thanks for the feedback.

https://codereview.chromium.org/341523002/diff/1/LayoutTests/fast/table/absol...
File LayoutTests/fast/table/absolute-table-percent-lengths-expected.html
(right):

https://codereview.chromium.org/341523002/diff/1/LayoutTests/fast/table/absol...
LayoutTests/fast/table/absolute-table-percent-lengths-expected.html:24:
div:nth-child(4) span.tbl { left: 0; bottom: 0; }
On 2014/06/17 20:57:43, Julien Chaffraix - PST wrote:
> I prefer to use simple selectors (class, id) when not required by the test. It
> makes the test more resilient (less selector code to run), more readable as it
> gives names to applied style too.

Yes, that's true.

I think you mentioned this in a previous review as well.

https://codereview.chromium.org/341523002/diff/1/LayoutTests/fast/table/absol...
File LayoutTests/fast/table/absolute-table-percent-lengths.html (right):

https://codereview.chromium.org/341523002/diff/1/LayoutTests/fast/table/absol...
LayoutTests/fast/table/absolute-table-percent-lengths.html:49: <div><span
class="tbl"><span class="cell">abc</span></span></div>
On 2014/06/17 20:57:43, Julien Chaffraix - PST wrote:
> [...] better as a check-layout.js [...]

OK, that makes sense, I'll use that instead.

[andersr, 2014-06-18 06:30:21]

PTAL

[Julien - ping for review, 2014-06-25 19:38:13]

lgtm

[commit-bot: I haz the power, 2014-06-25 19:38:28]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/andersr@opera.com/341523002/20001

[commit-bot: I haz the power, 2014-06-25 20:36:13]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_db...)
  android_blink_compile_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_re...)
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)
  linux_chromium_gn_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/bu...)
  mac_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/bu...)
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/12797)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/21540)

[commit-bot: I haz the power, 2014-06-25 20:45:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-25 20:45:29]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/bu...)

[andersr, 2014-06-27 12:22:38]

The CQ bit was checked by andersr@opera.com

[commit-bot: I haz the power, 2014-06-27 12:23:16]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/andersr@opera.com/341523002/60001

[commit-bot: I haz the power, 2014-06-27 13:29:42]

Change committed as 177101