Issue 341513002: DevTools: pass agent host id to the renderer (content).

Issue 341513002: DevTools: pass agent host id to the renderer (content). (Closed)

Created:
6 years, 6 months ago by pfeldman

Modified:
6 years, 6 months ago

Reviewers:
Tom Sepez, eustas, vsevik, jam

CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, vsevik, tzik, alecflett+watch_chromium.org, horo+watch_chromium.org, jam, serviceworker-reviews, yurys, paulirish+reviews_chromium.org, darin-cc_chromium.org, nhiroki, devtools-reviews_chromium.org, kinuko+serviceworker, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

DevTools: pass agent host id to the renderer (content). TBR=jam // for changes to implementations in content/. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278135

Patch Set 1 #

Patch Set 2 : Same w/ reattach. #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -35 lines)			Patch
M	content/browser/devtools/ipc_devtools_agent_host.cc	View	1	3 chunks	+3 lines, -4 lines	0 comments	Download
M	content/child/shared_worker_devtools_agent.h	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	content/child/shared_worker_devtools_agent.cc	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	content/common/devtools_messages.h	View	1	2 chunks	+6 lines, -3 lines	0 comments	Download
M	content/renderer/devtools/devtools_agent.h	View	1	3 chunks	+7 lines, -5 lines	0 comments	Download
M	content/renderer/devtools/devtools_agent.cc	View	1	3 chunks	+16 lines, -8 lines	0 comments	Download
M	content/renderer/devtools/devtools_agent_filter.cc	View		1 chunk	+7 lines, -7 lines	0 comments	Download
M	content/renderer/service_worker/embedded_worker_devtools_agent.h	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	content/renderer/service_worker/embedded_worker_devtools_agent.cc	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

pfeldman

+tsepez for devtools_messages.h. We are passing the string host id to the renderer side, it ...

6 years, 6 months ago (2014-06-17 13:01:18 UTC) #2

Tom Sepez

LGTM. Thanks for anticipating the question I would have asked :).

6 years, 6 months ago (2014-06-17 17:55:28 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/341513002/20001

6 years, 6 months ago (2014-06-18 15:49:58 UTC) #6

Message was sent while issue was closed.

Change committed as 278135

Expand Messages | Collapse Messages