[Suggestions] Ability to override the timeout parameter via Variations

Provide a way to override the request timeout parameter via Variations.

Default will be 200ms.

BUG=None
TEST=None

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277960

[Mathieu, 2014-06-17 18:04:39]

Hi, 

Can you have a look?

Thanks

[manzagop (departed), 2014-06-17 18:16:46]

LGTM up to comment.

https://codereview.chromium.org/341483007/diff/1/chrome/browser/search/sugges...
File chrome/browser/search/suggestions/suggestions_service.cc (right):

https://codereview.chromium.org/341483007/diff/1/chrome/browser/search/sugges...
chrome/browser/search/suggestions/suggestions_service.cc:101:
base::StringToInt(timeout, &request_timeout_ms_);
If returns false, fallback to the default value.

[Mathieu, 2014-06-17 19:49:44]

Thanks! Submitting.

https://codereview.chromium.org/341483007/diff/1/chrome/browser/search/sugges...
File chrome/browser/search/suggestions/suggestions_service.cc (right):

https://codereview.chromium.org/341483007/diff/1/chrome/browser/search/sugges...
chrome/browser/search/suggestions/suggestions_service.cc:101:
base::StringToInt(timeout, &request_timeout_ms_);
On 2014/06/17 18:16:45, manzagop wrote:
> If returns false, fallback to the default value.

Done.

[Mathieu, 2014-06-17 19:49:49]

The CQ bit was checked by mathp@chromium.org

[commit-bot: I haz the power, 2014-06-17 19:51:35]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mathp@chromium.org/341483007/20001

[commit-bot: I haz the power, 2014-06-17 19:51:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-17 19:51:37]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[beaudoin, 2014-06-17 20:46:35]

LGTM

[Mathieu, 2014-06-17 20:53:53]

The CQ bit was checked by mathp@chromium.org

[commit-bot: I haz the power, 2014-06-17 20:55:52]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mathp@chromium.org/341483007/20001

[commit-bot: I haz the power, 2014-06-18 07:02:42]

Change committed as 277960