Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Side by Side Diff: Source/devtools/front_end/timeline/TimelinePanel.js

Issue 341483005: Timeline: remove redundant header from frame statistics (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebased, fixed test Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * Copyright (C) 2012 Intel Inc. All rights reserved. 3 * Copyright (C) 2012 Intel Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 971 matching lines...) Expand 10 before | Expand all | Expand 10 after
982 this._updateSelectedRangeStats(); 982 this._updateSelectedRangeStats();
983 return; 983 return;
984 } 984 }
985 switch (this._selection.type()) { 985 switch (this._selection.type()) {
986 case WebInspector.TimelineSelection.Type.Record: 986 case WebInspector.TimelineSelection.Type.Record:
987 var record = /** @type {!WebInspector.TimelineModel.Record} */ (this ._selection.object()); 987 var record = /** @type {!WebInspector.TimelineModel.Record} */ (this ._selection.object());
988 if (this._tracingTimelineModel) { 988 if (this._tracingTimelineModel) {
989 var event = this._tracingTimelineModel.traceEventFrom(record); 989 var event = this._tracingTimelineModel.traceEventFrom(record);
990 this._buildSelectionDetailsForTraceEvent(event); 990 this._buildSelectionDetailsForTraceEvent(event);
991 } else { 991 } else {
992 WebInspector.TimelineUIUtils.generatePopupContent(record, this._ model, this._detailsLinkifier, this.showInDetails.bind(this, record.title()), th is._model.loadedFromFile()); 992 WebInspector.TimelineUIUtils.generateDetailsContent(record, this ._model, this._detailsLinkifier, this.showInDetails.bind(this, record.title()), this._model.loadedFromFile());
993 } 993 }
994 break; 994 break;
995 case WebInspector.TimelineSelection.Type.TraceEvent: 995 case WebInspector.TimelineSelection.Type.TraceEvent:
996 var event = /** @type {!WebInspector.TracingModel.Event} */ (this._s election.object()); 996 var event = /** @type {!WebInspector.TracingModel.Event} */ (this._s election.object());
997 this._buildSelectionDetailsForTraceEvent(event); 997 this._buildSelectionDetailsForTraceEvent(event);
998 break; 998 break;
999 case WebInspector.TimelineSelection.Type.Frame: 999 case WebInspector.TimelineSelection.Type.Frame:
1000 var frame = /** @type {!WebInspector.TimelineFrame} */ (this._select ion.object()); 1000 var frame = /** @type {!WebInspector.TimelineFrame} */ (this._select ion.object());
1001 if (frame.layerTree) { 1001 if (frame.layerTree) {
1002 var layersView = this._layersView(); 1002 var layersView = this._layersView();
1003 layersView.showLayerTree(frame.layerTree); 1003 layersView.showLayerTree(frame.layerTree);
1004 this._detailsView.setChildView(WebInspector.UIString("Frame Laye rs"), layersView); 1004 this._detailsView.setChildView(WebInspector.UIString("Frame Laye rs"), layersView);
1005 } else { 1005 } else {
1006 this.showInDetails(WebInspector.UIString("Frame Statistics"), We bInspector.TimelineUIUtils.generatePopupContentForFrame(this._lazyFrameModel, fr ame)); 1006 this.showInDetails(WebInspector.UIString("Frame Statistics"), We bInspector.TimelineUIUtils.generateDetailsContentForFrame(this._lazyFrameModel, frame));
1007 } 1007 }
1008 break; 1008 break;
1009 } 1009 }
1010 }, 1010 },
1011 1011
1012 /** 1012 /**
1013 * @param {!WebInspector.TracingModel.Event} event 1013 * @param {!WebInspector.TracingModel.Event} event
1014 */ 1014 */
1015 _buildSelectionDetailsForTraceEvent: function(event) 1015 _buildSelectionDetailsForTraceEvent: function(event)
1016 { 1016 {
(...skipping 439 matching lines...) Expand 10 before | Expand all | Expand 10 after
1456 * @param {!WebInspector.TimelineModel.Record} record 1456 * @param {!WebInspector.TimelineModel.Record} record
1457 * @return {boolean} 1457 * @return {boolean}
1458 */ 1458 */
1459 accept: function(record) 1459 accept: function(record)
1460 { 1460 {
1461 return !this._hiddenRecords[record.type()]; 1461 return !this._hiddenRecords[record.type()];
1462 }, 1462 },
1463 1463
1464 __proto__: WebInspector.TimelineModel.Filter.prototype 1464 __proto__: WebInspector.TimelineModel.Filter.prototype
1465 } 1465 }
OLDNEW
« no previous file with comments | « Source/devtools/front_end/timeline/TimelineFrameModel.js ('k') | Source/devtools/front_end/timeline/TimelineUIUtils.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698