Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 341483005: Timeline: remove redundant header from frame statistics (Closed)

Created:
6 years, 6 months ago by caseq
Modified:
6 years, 6 months ago
Reviewers:
yurys, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Timeline: remove redundant header from frame statistics - rename generatePopupContent.* to generateDetailsContent where appropriate; - change generateDetailsContentForFrame to use TimelineDetailsContentHelper, thus removing redundant header; - (drive-by) fix frame start time in case frames are built from trace events. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176397

Patch Set 1 #

Patch Set 2 : rebased, fixed test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -31 lines) Patch
M LayoutTests/inspector/timeline/timeline-node-reference.html View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/timeline/TimelineFrameModel.js View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelinePanel.js View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineUIUtils.js View 1 5 chunks +5 lines, -28 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
caseq
6 years, 6 months ago (2014-06-17 14:41:21 UTC) #1
yurys
lgtm
6 years, 6 months ago (2014-06-17 14:44:08 UTC) #2
caseq
The CQ bit was checked by caseq@chromium.org
6 years, 6 months ago (2014-06-17 14:56:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caseq@chromium.org/341483005/1
6 years, 6 months ago (2014-06-17 14:57:09 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-17 16:19:37 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/11713)
6 years, 6 months ago (2014-06-17 16:19:38 UTC) #6
caseq
The CQ bit was checked by caseq@chromium.org
6 years, 6 months ago (2014-06-18 05:41:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caseq@chromium.org/341483005/20001
6 years, 6 months ago (2014-06-18 05:41:45 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-18 06:47:01 UTC) #9
Message was sent while issue was closed.
Change committed as 176397

Powered by Google App Engine
This is Rietveld 408576698