Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issue 341483004: [DevTools] Add desktop device presets. (Closed)

Created:
6 years, 6 months ago by dgozman
Modified:
6 years, 6 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

[DevTools] Add desktop device presets. BUG=327641 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176409

Patch Set 1 #

Patch Set 2 : rebase, test fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -59 lines) Patch
M LayoutTests/inspector/device-emulation/device-emulation-test.js View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/ResponsiveDesignView.js View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/sdk/OverridesSupport.js View 1 9 chunks +60 lines, -57 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dgozman
Take a look please.
6 years, 6 months ago (2014-06-17 12:47:02 UTC) #1
pfeldman
lgtm
6 years, 6 months ago (2014-06-17 12:51:06 UTC) #2
dgozman
The CQ bit was checked by dgozman@chromium.org
6 years, 6 months ago (2014-06-18 09:38:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/341483004/20001
6 years, 6 months ago (2014-06-18 09:39:17 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-18 12:03:51 UTC) #5
Message was sent while issue was closed.
Change committed as 176409

Powered by Google App Engine
This is Rietveld 408576698