Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 341453002: [multi-profiles] Allow bringing up sign in UI even if all users are restricted per their policies (Closed)

Created:
6 years, 6 months ago by Nikita (slow)
Modified:
6 years, 6 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

[multi-profiles] Allow bringing up sign in UI even if all users are restricted per their policies * Don't allow launching GAIA sign in for user pod that is shown with multi-profile policy restriction * Always show policy bubble when hovering over user pod / clicking/tapping on it. BUG=385498 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278547

Patch Set 1 #

Patch Set 2 : comment #

Patch Set 3 : multi-profiles policy bubble follows action menu buton logic: is shown on pod hover/click #

Patch Set 4 : cleanup #

Patch Set 5 : rebase + show policy bubble on click even when there's only single pod #

Patch Set 6 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -12 lines) Patch
M chrome/browser/chromeos/login/users/user_manager.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/users/user_manager_impl.cc View 1 2 3 4 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/resources/login/display_manager.js View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/resources/login/user_pod_row.css View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/login/user_pod_row.js View 1 2 3 4 5 7 chunks +33 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Nikita (slow)
6 years, 6 months ago (2014-06-17 07:06:28 UTC) #1
ygorshenin1
lgtm
6 years, 6 months ago (2014-06-17 17:15:01 UTC) #2
Nikita (slow)
Please take another look, I've added couple related changes to css/js.
6 years, 6 months ago (2014-06-17 17:26:21 UTC) #3
Nikita (slow)
+Pavel for changes in login/user_pod_row.*
6 years, 6 months ago (2014-06-18 07:26:59 UTC) #4
Nikita (slow)
Changed implementation: now bubble is shown on click and cleared with other errors / bubbles.
6 years, 6 months ago (2014-06-19 12:10:10 UTC) #5
dzhioev (left Google)
On 2014/06/19 12:10:10, Nikita Kostylev wrote: > Changed implementation: now bubble is shown on click ...
6 years, 6 months ago (2014-06-19 16:32:33 UTC) #6
Nikita (slow)
The CQ bit was checked by nkostylev@chromium.org
6 years, 6 months ago (2014-06-19 16:35:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nkostylev@chromium.org/341453002/100001
6 years, 6 months ago (2014-06-19 16:36:23 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-20 00:35:48 UTC) #9
Message was sent while issue was closed.
Change committed as 278547

Powered by Google App Engine
This is Rietveld 408576698