Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 341383002: Oilpan: fix build after r176651 (Closed)

Created:
6 years, 6 months ago by sof
Modified:
6 years, 6 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, jamesr, krit, danakj, jbroman, blink-layers+watch_chromium.org, Rik, Stephen Chennney, pdr., rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Oilpan: fix build after r176651 Remove the use of transition types over JSONValues. R=haraken@chromium.org BUG= NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176677

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -20 lines) Patch
M Source/platform/graphics/GraphicsLayer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/GraphicsLayer.cpp View 11 chunks +19 lines, -19 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sof
Please take a look. Removed transition type use; moving JSONValue to the heap is something ...
6 years, 6 months ago (2014-06-21 06:33:26 UTC) #1
haraken
LGTM
6 years, 6 months ago (2014-06-21 06:55:07 UTC) #2
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 6 months ago (2014-06-21 07:34:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/341383002/1
6 years, 6 months ago (2014-06-21 07:36:03 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-21 07:36:28 UTC) #5
Message was sent while issue was closed.
Change committed as 176677

Powered by Google App Engine
This is Rietveld 408576698