Better rendering detection with DirectWrite.

Better rendering detection with DirectWrite.

When requesting embedded bitmaps, all sizes in a gridfit gasp range with a
bitmap in that range should be gridfit to the fullest extent possible.

Committed: https://skia.googlesource.com/skia/+/740c3f17f7f37fca5268b60a83448953f075d8d1

[bungeman-skia, 2014-06-20 21:55:35]

PS1 is an early pass at this, but the idea is that if there are bitmaps in a
gridfit gasp range, the rest of the gridfit gasp range should also be heavily
hinted. This fixes various issues with Courier New and SimSun (I'll have to be
sure to check dotum).

[eae, 2014-06-20 21:56:31]

Awesome, LGTM

[bungeman-skia, 2014-06-21 06:06:14]

I've run this change through the bots at
https://codereview.chromium.org/350443002/ with and without the suppression. I
believe it all looks good.

[eae, 2014-06-21 21:41:45]

On 2014/06/21 06:06:14, bungeman1 wrote:
> I've run this change through the bots at
> https://codereview.chromium.org/350443002/ with and without the suppression. I
> believe it all looks good.

I agree, all look equivalent or better,
virtual/antialiasedtext/fast/text/emphasis-vertical.html in particular looks _a
lot_ better.

[mtklein, 2014-06-23 14:59:20]

nits and comment requests, otherwise lgtm

https://codereview.chromium.org/341343002/diff/40001/src/ports/SkScalerContex...
File src/ports/SkScalerContext_win_dw.cpp (right):

https://codereview.chromium.org/341343002/diff/40001/src/ports/SkScalerContex...
src/ports/SkScalerContext_win_dw.cpp:44: static bool
renderingModeIsGridfit(DWriteFontTypeface* typeface, int size, PPEMRange* range)
{
static void expand_range_if_gridfit_only?

https://codereview.chromium.org/341343002/diff/40001/src/ports/SkScalerContex...
src/ports/SkScalerContext_win_dw.cpp:72: rangeTable->flags.raw.value ==
SkOTTableGridAndScanProcedure::GaspRange::behavior::Raw::GridfitMask)
// _only_ gridfit

https://codereview.chromium.org/341343002/diff/40001/src/ports/SkScalerContex...
src/ports/SkScalerContext_win_dw.cpp:84: static bool
hasBitmapStrike(DWriteFontTypeface* typeface, PPEMRange range) {
has_bitmap_strike, etc.

https://codereview.chromium.org/341343002/diff/40001/src/ports/SkScalerContex...
src/ports/SkScalerContext_win_dw.cpp:222: PPEMRange range = { bitmapPPEM,
bitmapPPEM};
This would be a good place to explain why we're doing this.

[bungeman-skia, 2014-06-23 15:13:50]

https://codereview.chromium.org/341343002/diff/40001/src/ports/SkScalerContex...
File src/ports/SkScalerContext_win_dw.cpp (right):

https://codereview.chromium.org/341343002/diff/40001/src/ports/SkScalerContex...
src/ports/SkScalerContext_win_dw.cpp:44: static bool
renderingModeIsGridfit(DWriteFontTypeface* typeface, int size, PPEMRange* range)
{
On 2014/06/23 14:59:20, mtklein wrote:
> static void expand_range_if_gridfit_only?

Done.

https://codereview.chromium.org/341343002/diff/40001/src/ports/SkScalerContex...
src/ports/SkScalerContext_win_dw.cpp:72: rangeTable->flags.raw.value ==
SkOTTableGridAndScanProcedure::GaspRange::behavior::Raw::GridfitMask)
On 2014/06/23 14:59:20, mtklein wrote:
> // _only_ gridfit

Done.

https://codereview.chromium.org/341343002/diff/40001/src/ports/SkScalerContex...
src/ports/SkScalerContext_win_dw.cpp:84: static bool
hasBitmapStrike(DWriteFontTypeface* typeface, PPEMRange range) {
On 2014/06/23 14:59:20, mtklein wrote:
> has_bitmap_strike, etc.

Done.

https://codereview.chromium.org/341343002/diff/40001/src/ports/SkScalerContex...
src/ports/SkScalerContext_win_dw.cpp:222: PPEMRange range = { bitmapPPEM,
bitmapPPEM};
On 2014/06/23 14:59:20, mtklein wrote:
> This would be a good place to explain why we're doing this.

Done.

[bungeman-skia, 2014-06-23 15:13:59]

The CQ bit was checked by bungeman@google.com

[commit-bot: I haz the power, 2014-06-23 15:14:22]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/bungeman@google.com/341343002/60001

[mtklein, 2014-06-23 15:20:34]

https://codereview.chromium.org/341343002/diff/60001/src/ports/SkScalerContex...
File src/ports/SkScalerContext_win_dw.cpp (right):

https://codereview.chromium.org/341343002/diff/60001/src/ports/SkScalerContex...
src/ports/SkScalerContext_win_dw.cpp:81: return;
This _may_ be redundant.

[commit-bot: I haz the power, 2014-06-23 15:29:27]

Change committed as 740c3f17f7f37fca5268b60a83448953f075d8d1