Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 341333004: Fix crash in _CMapLookupCallback (Closed)

Created:
6 years, 6 months ago by jun_fang
Modified:
6 years, 5 months ago
Reviewers:
palmer
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Visibility:
Public.

Description

fix a crash issue in _CMapLookupCallback BUG=382242 R=palmer@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/a26b328

Patch Set 1 #

Total comments: 1

Patch Set 2 : generation number checking #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M core/include/fpdfapi/fpdf_objects.h View 1 2 chunks +7 lines, -0 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp View 1 1 chunk +8 lines, -2 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jun_fang
Hi Chris, I fixed this crash issue. It's because two objects have the same number ...
6 years, 6 months ago (2014-06-21 00:26:31 UTC) #1
palmer
https://codereview.chromium.org/341333004/diff/1/core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp File core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp (right): https://codereview.chromium.org/341333004/diff/1/core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp#newcode1333 core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp:1333: return; But the caller is going to expect that ...
6 years, 6 months ago (2014-06-25 23:21:44 UTC) #2
jun_fang
6 years, 6 months ago (2014-06-26 00:13:26 UTC) #3
jun_fang
An object with a new generation number shall be used to replace the object with ...
6 years, 5 months ago (2014-07-03 05:19:22 UTC) #4
palmer
> An object with a new generation number shall be used to replace the object ...
6 years, 5 months ago (2014-07-07 18:25:44 UTC) #5
jun_fang
6 years, 5 months ago (2014-07-07 21:07:21 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as ra26b328 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698