Source/core/dom/Document.cpp - Issue 341273006: Protect an element while removing an attribute.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Document.cpp

Issue 341273006: Protect an element while removing an attribute. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Move the RefPtr to Document::adoptNode Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/Document.cpp

diff --git a/Source/core/dom/Document.cpp b/Source/core/dom/Document.cpp

index 365e290fc1a94714532c9ed034b6ea318519f9da..f681ab799f311d89ac3a7dee424d65f1fd1e3661 100644

--- a/Source/core/dom/Document.cpp

+++ b/Source/core/dom/Document.cpp

@@ -1023,8 +1023,8 @@ PassRefPtrWillBeRawPtr<Node> Document::adoptNode(PassRefPtrWillBeRawPtr<Node> so

return nullptr;

case ATTRIBUTE_NODE: {

Attr* attr = toAttr(source.get());

- if (attr->ownerElement())

- attr->ownerElement()->removeAttributeNode(attr, exceptionState);

+ if (RefPtrWillBeRawPtr<Element> ownerElement = attr->ownerElement())

+ ownerElement->removeAttributeNode(attr, exceptionState);

break;

}

default:

« no previous file with comments | « LayoutTests/http/tests/misc/adopt-iframe-src-attr-after-remove-expected.txt ('k') | no next file » | no next file with comments »