Source/core/dom/Element.cpp - Issue 341273006: Protect an element while removing an attribute.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Element.cpp

Issue 341273006: Protect an element while removing an attribute. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: RefPtr->RefPtrWillBeRawPtr Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/Element.cpp

diff --git a/Source/core/dom/Element.cpp b/Source/core/dom/Element.cpp

index b0b07eb1aeff28a2aa0bfc1f950aafa6d18b7bf6..ea32fe06aae8d5c593de7d6710e43ae867a353ca 100644

--- a/Source/core/dom/Element.cpp

+++ b/Source/core/dom/Element.cpp

@@ -2861,6 +2861,7 @@ void Element::didModifyAttribute(const QualifiedName& name, const AtomicString&

void Element::didRemoveAttribute(const QualifiedName& name)

{

+ RefPtrWillBeRawPtr<Element> protect(this);

attributeChanged(name, nullAtom);

InspectorInstrumentation::didRemoveDOMAttr(this, name.localName());

dispatchSubtreeModifiedEvent();