LayoutTests/http/tests/misc/adopt-iframe-src-attr-after-remove.html - Issue 341273006: Protect an element while removing an attribute.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/http/tests/misc/adopt-iframe-src-attr-after-remove.html

Issue 341273006: Protect an element while removing an attribute. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 We pass if we don't crash under ASAN.
	esprehn 2014/06/20 20:01:30 Missing doctype. Missing doctype.
	2 <iframe id=i src="../navigation/resources/blank.txt"></iframe>
	esprehn 2014/06/20 20:01:31 Can we use iframe instead of "i"? Can we use iframe instead of "i"?
	3 <script>

	4 if (window.testRunner) {

	5 testRunner.dumpAsText();

	6 testRunner.waitUntilDone();

	7 }

	8

	9 window.onload = function()

	10 {

	11 i.parentNode.removeChild(i);
	esprehn 2014/06/20 20:01:30 i.remove(); i.remove();
	12 gc();

	13 }

	14

	15 document.addEventListener("DOMContentLoaded", function() {

	16 setTimeout(function() {

	17 document.adoptNode(i.attributes["src"]);
	esprehn 2014/06/20 20:01:30 Just use removeAttribute? I don't know why you're Just use removeAttribute? I don't know why you're adopting the Attr node like this. Nate Chapin 2014/06/20 20:17:42 I was building this off of a clusterfuzz testcase, Show quoted text On 2014/06/20 20:01:30, esprehn wrote: > Just use removeAttribute? I don't know why you're adopting the Attr node like > this. I was building this off of a clusterfuzz testcase, so I left it minimally modified. I suspect removeAttribute would suffice.
	18 if (window.testRunner)

	19 testRunner.notifyDone();

	20 }, 0);

	21 }, false);

	22 </script>

OLD	NEW