Chromium Code Reviews
Help | Chromium Project | Sign in
(65)

Issue 3412031: GTTF: Use different port number for all types of TestServer. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 6 months ago by Paweł Hajdan Jr.
Modified:
3 years, 10 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

GTTF: Use different port number for all types of TestServer. Jay Civelli has noticed it should help with flakiness. BUG=40932 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60632

Patch Set 1 #

Total comments: 1

Patch Set 2 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M net/test/test_server.cc View 1 1 chunk +6 lines, -2 lines 0 comments Download
Commit: CQ not working?

Messages

Total messages: 4 (0 generated)
Paweł Hajdan Jr.
4 years, 6 months ago (2010-09-24 16:45:36 UTC) #1
Jay Civelli
LGTM
4 years, 6 months ago (2010-09-24 16:46:54 UTC) #2
mal
Should BUG= http://crbug.com/40932 ?
4 years, 6 months ago (2010-09-24 22:30:06 UTC) #3
Jay Civelli
4 years, 6 months ago (2010-09-25 01:12:10 UTC) #4
http://codereview.chromium.org/3412031/diff/1/2
File net/test/test_server.cc (right):

http://codereview.chromium.org/3412031/diff/1/2#newcode54
net/test/test_server.cc:54: return 9643;
I just realized some hard-coded test files expect 9666 for the bad https server
which is supposed to be the EXPIRED_CERT.
Please make sure to keep 9666 there.
(the port value for TYPE_HTTPS_MISMATCHED_HOSTNAME does not matter).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ecdb341-tainted