Issue 3412031: GTTF: Use different port number for all types of TestServer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3412031: GTTF: Use different port number for all types of TestServer. (Closed)

Created:
10 years, 3 months ago by Paweł Hajdan Jr.

Modified:
9 years, 7 months ago

Reviewers:
mal, Sam Kerner (Chrome), Jay Civelli

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Visibility:
Public.

Description

GTTF: Use different port number for all types of TestServer. Jay Civelli has noticed it should help with flakiness. BUG=40932 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60632

Patch Set 1 #

Total comments: 1

Patch Set 2 : fixes #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
	M	net/test/test_server.cc	View	1	1 chunk	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jay Civelli

10 years, 3 months ago (2010-09-25 01:12:10 UTC) #4

http://codereview.chromium.org/3412031/diff/1/2
File net/test/test_server.cc (right):

http://codereview.chromium.org/3412031/diff/1/2#newcode54
net/test/test_server.cc:54: return 9643;
I just realized some hard-coded test files expect 9666 for the bad https server
which is supposed to be the EXPIRED_CERT.
Please make sure to keep 9666 there.
(the port value for TYPE_HTTPS_MISMATCHED_HOSTNAME does not matter).

Expand Messages | Collapse Messages