Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 341193009: Include Event.h in fewer header files (Closed)

Created:
6 years, 6 months ago by philipj_slow
Modified:
6 years, 6 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, aandrey+blink_chromium.org, alecflett+watch_chromium.org, darktears, apavlov+blink_chromium.org, arv+blink, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-bindings_chromium.org, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, Rik, caseq+blink_chromium.org, devtools-reviews_chromium.org, dglazkov+blink, krit, dstockwell, eae+blinkwatch, ed+blinkwatch_opera.com, eric.carlson_apple.com, Eric Willigers, eustas+blink_chromium.org, falken, feature-media-reviews_chromium.org, f(malita), fs, gyuyoung.kim_webkit.org, horo+watch_chromium.org, jsbell+serviceworker_chromium.org, kinuko+serviceworker, kinuko+fileapi, kouhei+svg_chromium.org, loislo+blink_chromium.org, lushnikov+blink_chromium.org, malch+blink_chromium.org, michaeln, Mike Lawther (Google), nhiroki, paulirish+reviews_chromium.org, pdr., pfeldman+blink_chromium.org, philipj_slow, rjwright, rwlbuis, Stephen Chennney, sergeyv+blink_chromium.org, serviceworker-reviews, shans, sof, Steve Block, Timothy Loh, timvolodine, tommyw+watchlist_chromium.org, tzik, vsevik+blink_chromium.org, yurys+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Include Event.h in fewer header files Mostly due to the ExecutionContext.h change, this greatly reduces recompilation when touching Event.h, from 1392 to 444 steps locally. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176684

Patch Set 1 #

Patch Set 2 : rebase + NullExecutionContext fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -7 lines) Patch
M Source/bindings/v8/WorkerScriptController.h View 2 chunks +1 line, -1 line 0 comments Download
M Source/bindings/v8/WorkerScriptController.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/animation/AnimationTimeline.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/ExecutionContext.h View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/dom/ExecutionContext.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/editing/FrameSelection.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/frame/DeviceSingleWindowEventController.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/frame/EventHandlerRegistry.h View 1 chunk +3 lines, -1 line 0 comments Download
M Source/core/html/HTMLDetailsElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLDialogElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLSelectElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/ime/InputMethodContext.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/inspector/AsyncCallStackTracker.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/inspector/InspectorDOMDebuggerAgent.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/svg/SVGScriptElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/svg/animation/SVGSMILElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/testing/NullExecutionContext.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download
M Source/modules/battery/BatteryManager.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/filesystem/InspectorFileSystemAgent.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/mediasource/SourceBuffer.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/mediastream/MediaStreamTrack.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/netinfo/NetworkInformation.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/notifications/Notification.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorker.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
philipj_slow
PTAL
6 years, 6 months ago (2014-06-21 13:13:03 UTC) #1
abarth-chromium
lgtm
6 years, 6 months ago (2014-06-21 13:59:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/341193009/20001
6 years, 6 months ago (2014-06-21 14:00:17 UTC) #3
commit-bot: I haz the power
6 years, 6 months ago (2014-06-21 14:03:18 UTC) #4
Message was sent while issue was closed. 
Change committed as 176684

Powered by Google App Engine
This is Rietveld 408576698