Issue 341183002: Fixed build on Windows with Cygwin (get_syzygy_binaries script).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 341183002: Fixed build on Windows with Cygwin (get_syzygy_binaries script). (Closed)

Created:
6 years, 6 months ago by Matt Giuca

Modified:
6 years, 6 months ago

Reviewers:
chrisha

CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, calamity

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fixed build on Windows with Cygwin (get_syzygy_binaries script). 1. Allow get_syzygy_binaries to run in cygwin. 2. On cygwin, get_syzygy_binaries makes all of the binaries it unpacks executable (to avoid "permission denied" errors during compilation). BUG=386911 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278748

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	build/get_syzygy_binaries.py	View		2 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

chrisha

Thanks for fixing this, and sorry, I always forget about Cygwin :( lgtm

6 years, 6 months ago (2014-06-20 13:11:22 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mgiuca@chromium.org/341183002/1

6 years, 6 months ago (2014-06-20 14:40:48 UTC) #4

Matt Giuca

6 years, 6 months ago (2014-06-22 23:24:38 UTC) #6

Message was sent while issue was closed.

Thanks for committing.

Well according to my manager, Cygwin is no longer officially supported, so we
shouldn't be expected to keep maintaining it. (But since I'm still using it --
thanks.)

Expand Messages | Collapse Messages