LayoutTests/fast/multicol/widows.html - Issue 341103002: [New Multicolumn] Remove unnecessary calls to setRegionBasedColumnsEnabled.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/multicol/widows.html

Issue 341103002: [New Multicolumn] Remove unnecessary calls to setRegionBasedColumnsEnabled. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="../../resources/js-test.js"></script>	2 <script src="../../resources/js-test.js"></script>

3 <script>	3 <script>

4 description("Test column balancer behavior when widows requirements are high , and there's need for an early break to honor widows");	4 description("Test column balancer behavior when widows requirements are high , and there's need for an early break to honor widows");

5 if (window.internals)

6 internals.settings.setRegionBasedColumnsEnabled(true);

7 </script>	5 </script>

8 <p>The 5 lines should all be in the second column.</p>	6 <p>The 5 lines should all be in the second column.</p>

9 <div id="mc" style="-webkit-columns:3; columns:3; -webkit-column-rule:solid; lin e-height:50px; orphans:1; widows:5;">	7 <div id="mc" style="-webkit-columns:3; columns:3; -webkit-column-rule:solid; lin e-height:50px; orphans:1; widows:5;">

10 <span id="inFirstColumn"><br></span>	8 <span id="inFirstColumn"><br></span>

11 <span id="first">line<br></span>	9 <span id="first">line<br></span>

12 line<br>	10 line<br>

13 line<br>	11 line<br>

14 line<br>	12 line<br>

15 <span id="last">line<br></span>	13 <span id="last">line<br></span>

16 </div>	14 </div>

17 <script>	15 <script>

18 shouldBe("mc.offsetHeight", "250");	16 shouldBe("mc.offsetHeight", "250");

19 shouldBe("first.offsetTop", "inFirstColumn.offsetTop");	17 shouldBe("first.offsetTop", "inFirstColumn.offsetTop");

20 shouldBeGreaterThan("first.offsetLeft", "inFirstColumn.offsetLeft");	18 shouldBeGreaterThan("first.offsetLeft", "inFirstColumn.offsetLeft");

21 shouldBe("last.offsetLeft", "first.offsetLeft");	19 shouldBe("last.offsetLeft", "first.offsetLeft");

22 </script>	20 </script>

OLD	NEW

« no previous file with comments | « LayoutTests/fast/multicol/transform-inside-opacity.html ('k') | LayoutTests/fast/multicol/widows2.html » ('j') | no next file with comments »