LayoutTests/fast/multicol/newmulticol/direct-child-column-span-all.html - Issue 341103002: [New Multicolumn] Remove unnecessary calls to setRegionBasedColumnsEnabled.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/multicol/newmulticol/direct-child-column-span-all.html

Issue 341103002: [New Multicolumn] Remove unnecessary calls to setRegionBasedColumnsEnabled. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/multicol/newmulticol/column-rules-fixed-height.html ('k') | LayoutTests/fast/multicol/newmulticol/fixed-height-fill-auto.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <style type="text/css">	4 <style type="text/css">

5 #article1 { -webkit-columns: 1; }	5 #article1 { -webkit-columns: 1; }

6 #p1 { -webkit-column-span: all; }	6 #p1 { -webkit-column-span: all; }

7 </style>	7 </style>

8

9 <script type="text/javascript">

10 if(window.internals)

11 internals.settings.setRegionBasedColumnsEnabled(true);

12 </script>

13 </head>	8 </head>

14 <body>	9 <body>

15 <div id="article1">	10 <div id="article1">

16 <p id="p1">PASS</p>	11 <p id="p1">PASS</p>

17 </div>	12 </div>

18 <div>Test passes if it doesn't crash or assert.</div>	13 <div>Test passes if it doesn't crash or assert.</div>

19 <div>Test added as part of <a href="https://code.google.com/p/chromium/i ssues/detail?id=242129">242129 - ASSERTION FAILED: !node \|\| node->isElementNode( ), UNKNOWN in WebCore::RenderBlock::clone</a></div>	14 <div>Test added as part of <a href="https://code.google.com/p/chromium/i ssues/detail?id=242129">242129 - ASSERTION FAILED: !node \|\| node->isElementNode( ), UNKNOWN in WebCore::RenderBlock::clone</a></div>

20 </body>	15 </body>

21 </html>	16 </html>

OLD	NEW