LayoutTests/fast/multicol/newmulticol/balance-images.html - Issue 341103002: [New Multicolumn] Remove unnecessary calls to setRegionBasedColumnsEnabled.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/multicol/newmulticol/balance-images.html

Issue 341103002: [New Multicolumn] Remove unnecessary calls to setRegionBasedColumnsEnabled. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/multicol/newmulticol/avoid-column-break-inside.html ('k') | LayoutTests/fast/multicol/newmulticol/balance-maxheight1.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <title>balancing multicol with max-height</title>	4 <title>balancing multicol with max-height</title>

5 <script src="../../../resources/js-test.js"></script>	5 <script src="../../../resources/js-test.js"></script>

6 <script>	6 <script>

7 if (window.testRunner)	7 if (window.testRunner)

8 testRunner.dumpAsText();	8 testRunner.dumpAsText();

9 if (window.internals)

10 internals.settings.setRegionBasedColumnsEnabled(true);

11 </script>	9 </script>

12 <style>	10 <style>

13 img { display:block; height:123px; }	11 img { display:block; height:123px; }

14 </style>	12 </style>

15 </head>	13 </head>

16 <body>	14 <body>

17 <p>There should be a 2 by 2 image grid below.</p>	15 <p>There should be a 2 by 2 image grid below.</p>

18 <div id="mc" style="-webkit-columns:3; columns:3; orphans:1; widows:1; color :olive; background:olive;">	16 <div id="mc" style="-webkit-columns:3; columns:3; orphans:1; widows:1; color :olive; background:olive;">

19 <img src="../resources/ipad.jpg">	17 <img src="../resources/ipad.jpg">

20 <img src="../resources/ipad.jpg">	18 <img src="../resources/ipad.jpg">

21 <img src="../resources/ipad.jpg">	19 <img src="../resources/ipad.jpg">

22 <img src="../resources/ipad.jpg">	20 <img src="../resources/ipad.jpg">

23 </div>	21 </div>

24 <script>	22 <script>

25 shouldBe("mc.offsetHeight", "246");	23 shouldBe("mc.offsetHeight", "246");

26 shouldBe("document.documentElement.scrollWidth", "document.documentElement .clientWidth");	24 shouldBe("document.documentElement.scrollWidth", "document.documentElement .clientWidth");

27 </script>	25 </script>

28 </body>	26 </body>

29 </html>	27 </html>

OLD	NEW