chrome/browser/bitmap_fetcher/bitmap_fetcher_service.cc - Issue 341083008: [AiS] Fix ownership issue for image service observers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/bitmap_fetcher/bitmap_fetcher_service.cc

Issue 341083008: [AiS] Fix ownership issue for image service observers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@img-bridge

Patch Set: Re-upload. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/omnibox/answers_image_bridge.cc ('k') | chrome/browser/bitmap_fetcher/bitmap_fetcher_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/bitmap_fetcher/bitmap_fetcher_service.cc

diff --git a/chrome/browser/bitmap_fetcher/bitmap_fetcher_service.cc b/chrome/browser/bitmap_fetcher/bitmap_fetcher_service.cc

index 18278a6d08188629e4007f81664ab63fa9f38ff3..e02ea5a0e1edc9c09b2a3224bc45f2f9e64f05d4 100644

--- a/chrome/browser/bitmap_fetcher/bitmap_fetcher_service.cc

+++ b/chrome/browser/bitmap_fetcher/bitmap_fetcher_service.cc

@@ -45,10 +45,6 @@ BitmapFetcherRequest::BitmapFetcherRequest(

}

BitmapFetcherRequest::~BitmapFetcherRequest() {

- SkBitmap empty_bitmap;

- // OnImageChanged with an empty bitmap signifies a completed request.

- observer_->OnImageChanged(request_id_, empty_bitmap);

}

void BitmapFetcherRequest::NotifyImageChanged(const SkBitmap& bitmap) {