Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Unified Diff: net/quic/quic_connection.cc

Issue 341083007: Land Recent QUIC Changes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Compile fix Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_connection.h ('k') | net/quic/quic_connection_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_connection.cc
diff --git a/net/quic/quic_connection.cc b/net/quic/quic_connection.cc
index c7fb7c040ceaaaba5a5ea3905ad5a6a1dbc41db4..a977b3fdcdb8d13d50f70c0a40d27721ddff9dc2 100644
--- a/net/quic/quic_connection.cc
+++ b/net/quic/quic_connection.cc
@@ -1241,10 +1241,10 @@ void QuicConnection::WritePendingRetransmissions() {
// Retransmitted data packets do not use FEC, even when it's enabled.
// Retransmitted packets use the same sequence number length as the
// original.
- // Flush the packet creator before making a new packet.
+ // Flush the packet generator before making a new packet.
// TODO(ianswett): Implement ReserializeAllFrames as a separate path that
// does not require the creator to be flushed.
- Flush();
+ packet_generator_.FlushAllQueuedFrames();
SerializedPacket serialized_packet = packet_generator_.ReserializeAllFrames(
pending.retransmittable_frames.frames(),
pending.sequence_number_length);
@@ -1780,7 +1780,7 @@ void QuicConnection::SendConnectionClosePacket(QuicErrorCode error,
frame->error_code = error;
frame->error_details = details;
packet_generator_.AddControlFrame(QuicFrame(frame));
- Flush();
+ packet_generator_.FlushAllQueuedFrames();
}
void QuicConnection::CloseConnection(QuicErrorCode error, bool from_peer) {
@@ -1842,10 +1842,6 @@ void QuicConnection::set_max_packet_length(size_t length) {
return packet_generator_.set_max_packet_length(length);
}
-void QuicConnection::Flush() {
- packet_generator_.FlushAllQueuedFrames();
-}
-
bool QuicConnection::HasQueuedData() const {
return pending_version_negotiation_packet_ ||
!queued_packets_.empty() || packet_generator_.HasQueuedFrames();
« no previous file with comments | « net/quic/quic_connection.h ('k') | net/quic/quic_connection_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698