Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 341083007: Land Recent QUIC Changes. (Closed)

Created:
6 years, 6 months ago by ramant (doing other things)
Modified:
6 years, 6 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, Jana, wtc, jar (doing other things), alyssar, avd, Ian Swett, Robbie Shade
Project:
chromium
Visibility:
Public.

Description

Land Recent QUIC Changes. Introduce QUIC_VERSION_20: allowing endpoints to set different stream/session flow control windows. Two new tags kSFCW, kCFCW for stream flow control window and session (connection) flow control windows respectively. kIFCW is still used for older versions <= QUIC_VERSION_19. kIFCW has the same value as kCFCW. Most of this CL is copy/paste code for setting/getting the new tags. New values are set in quic_client_bin.cc (and quic_stream_factory.cc), and processed in quic_session.cc and reliable_quic_stream.cc rtenneti: When merging into Chromium, you should add something like: config.SetInitialStreamFlowControlWindowToSend(kInitialReceiveWindow); config.SetInitialSessionFlowControlWindowToSend(kInitialReceiveWindow); just before *session = new QuicClientSession(...) in quic_stream_factory.cc Introduce QUIC_VERSION_20: allowing endpoints to set different stream/session flow control windows. Merge internal change: 69557631 https://codereview.chromium.org/339803004/ Added SetUserAgentID method to QuicClient which calls crypto_config_'s set_user_agent_id method. The following is the internal CL description. Add command line flags to allow enabling QUIC UDP proxying based on Chrome version modifers (canary/dev/beta/stable) included in the CHLO UAID. Command line flags to allow QUIC UDP proxying for specific Chrome versions. Merge internal change: 69473619 https://codereview.chromium.org/346853003/ Refactoring QuicClient so it doesn't own the epoll server it uses. We'll be using QuicClient to health check backends for UdpProxying, so it'll need to use the siloed internal server's EpollServer. Refactoring quic client to not own the epoll server Merge internal change: 69460313 https://codereview.chromium.org/344053002/ Fix a bug where QUIC ack frames were not bundled with crypto stream frames when there was a missing packet. Moved the code to ensure Crypto stream frames weren't sent with other retransmittable frames from CryptoStreamFrame into QuicPacketGenerator. Merge internal change: 69415222 https://codereview.chromium.org/342983004/ R=rch@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278652

Patch Set 1 #

Patch Set 2 : Rebase with TOT #

Patch Set 3 : Compile fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+593 lines, -140 lines) Patch
M net/quic/crypto/crypto_handshake_message.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/crypto/crypto_protocol.h View 1 chunk +5 lines, -1 line 0 comments Download
M net/quic/quic_config.h View 3 chunks +28 lines, -1 line 0 comments Download
M net/quic/quic_config.cc View 5 chunks +63 lines, -1 line 0 comments Download
M net/quic/quic_config_test.cc View 6 chunks +35 lines, -6 lines 0 comments Download
M net/quic/quic_connection.h View 1 chunk +0 lines, -4 lines 0 comments Download
M net/quic/quic_connection.cc View 3 chunks +3 lines, -7 lines 0 comments Download
M net/quic/quic_connection_test.cc View 4 chunks +25 lines, -7 lines 0 comments Download
M net/quic/quic_crypto_stream.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M net/quic/quic_end_to_end_unittest.cc View 1 chunk +5 lines, -1 line 0 comments Download
M net/quic/quic_flow_controller_test.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M net/quic/quic_packet_creator.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/quic_packet_creator.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M net/quic/quic_packet_generator.cc View 2 chunks +10 lines, -1 line 0 comments Download
M net/quic/quic_packet_generator_test.cc View 7 chunks +10 lines, -10 lines 0 comments Download
M net/quic/quic_protocol.h View 1 3 chunks +5 lines, -3 lines 0 comments Download
M net/quic/quic_protocol.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M net/quic/quic_session.cc View 2 chunks +41 lines, -12 lines 0 comments Download
M net/quic/quic_session_test.cc View 8 chunks +69 lines, -17 lines 0 comments Download
M net/quic/quic_stream_factory.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/reliable_quic_stream.cc View 2 chunks +32 lines, -8 lines 0 comments Download
M net/quic/reliable_quic_stream_test.cc View 2 chunks +3 lines, -1 line 0 comments Download
M net/quic/test_tools/mock_quic_dispatcher.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M net/quic/test_tools/quic_config_peer.h View 1 chunk +7 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_config_peer.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 1 chunk +4 lines, -1 line 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 1 1 chunk +6 lines, -1 line 0 comments Download
M net/tools/quic/end_to_end_test.cc View 6 chunks +105 lines, -4 lines 0 comments Download
M net/tools/quic/quic_client.h View 4 chunks +12 lines, -4 lines 0 comments Download
M net/tools/quic/quic_client.cc View 8 chunks +17 lines, -9 lines 0 comments Download
M net/tools/quic/quic_client_bin.cc View 1 4 chunks +19 lines, -6 lines 0 comments Download
M net/tools/quic/quic_client_session_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/tools/quic/quic_server_session_test.cc View 1 chunk +6 lines, -1 line 0 comments Download
M net/tools/quic/quic_spdy_client_stream_test.cc View 1 chunk +5 lines, -1 line 0 comments Download
M net/tools/quic/quic_spdy_server_stream_test.cc View 1 chunk +5 lines, -1 line 0 comments Download
M net/tools/quic/test_tools/mock_quic_dispatcher.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_client.h View 5 chunks +11 lines, -2 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_client.cc View 10 chunks +24 lines, -14 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_utils.h View 1 chunk +4 lines, -1 line 0 comments Download
M net/tools/quic/test_tools/quic_test_utils.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
ramant (doing other things)
6 years, 6 months ago (2014-06-19 22:29:53 UTC) #1
ramant (doing other things)
On 2014/06/19 22:29:53, ramant wrote: This CL doesn't include BBR and StrikeRegister changes. thanks raman
6 years, 6 months ago (2014-06-19 22:32:30 UTC) #2
Ryan Hamilton
lgtm
6 years, 6 months ago (2014-06-19 23:55:23 UTC) #3
ramant (doing other things)
The CQ bit was checked by rtenneti@chromium.org
6 years, 6 months ago (2014-06-20 00:54:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/341083007/20001
6 years, 6 months ago (2014-06-20 00:56:01 UTC) #5
ramant (doing other things)
The CQ bit was checked by rtenneti@chromium.org
6 years, 6 months ago (2014-06-20 01:28:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/341083007/40001
6 years, 6 months ago (2014-06-20 01:31:22 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-20 09:09:25 UTC) #8
Message was sent while issue was closed.
Change committed as 278652

Powered by Google App Engine
This is Rietveld 408576698