Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 341083006: suppress unaddr error at InProcessBrowserTest::AddBlankTabAndShow (Closed)

Created:
6 years, 6 months ago by zhaoqin
Modified:
6 years, 6 months ago
Reviewers:
Sam McNally, blundell
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

suppress unaddr error at InProcessBrowserTest::AddBlankTabAndShow TBR=sammc@chromium.org,blundell@chromium.org BUG=313788 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278422

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M tools/valgrind/drmemory/suppressions.txt View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
zhaoqin
6 years, 6 months ago (2014-06-19 18:14:57 UTC) #1
zhaoqin
Committed patchset #1 manually as r278422 (presubmit successful).
6 years, 6 months ago (2014-06-19 18:15:22 UTC) #2
blundell
Out of curiosity, why am I on this CL/bug?
6 years, 6 months ago (2014-06-20 14:21:19 UTC) #3
zhaoqin
On 2014/06/20 14:21:19, blundell wrote: > Out of curiosity, why am I on this CL/bug? ...
6 years, 6 months ago (2014-06-20 14:48:57 UTC) #4
blundell
On 2014/06/20 14:48:57, zhaoqin wrote: > On 2014/06/20 14:21:19, blundell wrote: > > Out of ...
6 years, 6 months ago (2014-06-20 18:21:25 UTC) #5
zhaoqin
6 years, 6 months ago (2014-06-20 18:25:01 UTC) #6
Message was sent while issue was closed.
On 2014/06/20 18:21:25, blundell wrote:
> On 2014/06/20 14:48:57, zhaoqin wrote:
> > On 2014/06/20 14:21:19, blundell wrote:
> > > Out of curiosity, why am I on this CL/bug?
> > 
> > because your recent CL touched the code around
> > (https://codereview.chromium.org/325443002, r275988), which means you might
> have
> > better idea of the code.
> 
> Thanks. I don't think that CL had anything to do with these problems.

This bug has been sitting there for awhile, if you happen to know anyone that is
familiar with that part of the code, feel free to add him/her to the issue
tracker.

Powered by Google App Engine
This is Rietveld 408576698