Wire up component cloud policy to device local accounts.

chrome/browser/chromeos/policy/device_local_account_policy_service.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_POLICY_DEVICE_LOCAL_ACCOUNT_POLICY_SERVICE_H_
 #define CHROME_BROWSER_CHROMEOS_POLICY_DEVICE_LOCAL_ACCOUNT_POLICY_SERVICE_H_
 
 #include <map>
 #include <set>
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
+#include "base/files/file_path.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
 #include "base/observer_list.h"
 #include "chrome/browser/chromeos/extensions/device_local_account_external_policy_loader.h"
 #include "chrome/browser/chromeos/policy/device_local_account_external_data_manager.h"
 #include "chrome/browser/chromeos/settings/cros_settings.h"
 #include "components/policy/core/common/cloud/cloud_policy_core.h"
 #include "components/policy/core/common/cloud/cloud_policy_store.h"
 
@@ skipping 17 matching lines @@
 class DeviceLocalAccountPolicyStore;
 class DeviceManagementService;
 
 // The main switching central that downloads, caches, refreshes, etc. policy for
 // a single device-local account.
 class DeviceLocalAccountPolicyBroker {
  public:
   // |task_runner| is the runner for policy refresh tasks.
   DeviceLocalAccountPolicyBroker(
       const DeviceLocalAccount& account,
+      const base::FilePath& component_policy_cache_path,
       scoped_ptr<DeviceLocalAccountPolicyStore> store,
       scoped_refptr<DeviceLocalAccountExternalDataManager>
           external_data_manager,
       const scoped_refptr<base::SequencedTaskRunner>& task_runner);
   ~DeviceLocalAccountPolicyBroker();
 
   // Initialize the broker, loading its |store_|.
   void Initialize();
 
   // For the difference between |account_id| and |user_id|, see the
@@ skipping 18 matching lines @@
       DeviceManagementService* device_management_service,
       scoped_refptr<net::URLRequestContextGetter> request_context);
 
   // Reads the refresh delay from policy and configures the refresh scheduler.
   void UpdateRefreshDelay();
 
   // Retrieves the display name for the account as stored in policy. Returns an
   // empty string if the policy is not present.
   std::string GetDisplayName() const;
 
+  // Returns a directory where component policy for this account can be cached.

[bartfab (slow), 2014/06/20 09:17:25]

Nit: s/ a / the /

[Joao da Silva, 2014/06/20 11:48:46]

Obsolete in the next CL

+  // The DeviceLocalAccountPolicyService takes care of cleaning up caches of

[bartfab (slow), 2014/06/20 09:17:25]

Nit: s /caches of/caches belonging to/

[Joao da Silva, 2014/06/20 11:48:45]

Obsolete in the next CL

+  // accounts that have been removed.
+  base::FilePath GetComponentPolicyCachePath() const;
+
  private:
   const std::string account_id_;
   const std::string user_id_;
+  const base::FilePath component_policy_cache_path_;
   const scoped_ptr<DeviceLocalAccountPolicyStore> store_;
   scoped_refptr<DeviceLocalAccountExternalDataManager> external_data_manager_;
   scoped_refptr<chromeos::DeviceLocalAccountExternalPolicyLoader>
       extension_loader_;
   CloudPolicyCore core_;
 
   DISALLOW_COPY_AND_ASSIGN(DeviceLocalAccountPolicyBroker);
 };
 
 // Manages user policy blobs for device-local accounts present on the device.
 // The actual policy blobs are brokered by session_manager (to prevent file
 // manipulation), and we're making signature checks on the policy blobs to
 // ensure they're issued by the device owner.
 class DeviceLocalAccountPolicyService : public CloudPolicyStore::Observer {
  public:
   // Interface for interested parties to observe policy changes.
   class Observer {
    public:
     virtual ~Observer() {}
 
     // Policy for the given |user_id| has changed.
     virtual void OnPolicyUpdated(const std::string& user_id) = 0;
 
     // The list of accounts has been updated.
     virtual void OnDeviceLocalAccountsChanged() = 0;
+
+    // The given |broker| is about to be destroyed.
+    virtual void OnBrokerShutdown(DeviceLocalAccountPolicyBroker* broker) {}

[bartfab (slow), 2014/06/20 09:17:25]

Nit: Instead of exposing the internal detail that policy for device-local
accounts is handled by Brokers, how about calling this something like
OnPolicyServiceShutdown(const std::string& user_id)?

[Joao da Silva, 2014/06/20 11:48:45]

This method has been removed.

   };
 
   DeviceLocalAccountPolicyService(
       chromeos::SessionManagerClient* session_manager_client,
       chromeos::DeviceSettingsService* device_settings_service,
       chromeos::CrosSettings* cros_settings,
       scoped_refptr<base::SequencedTaskRunner> store_background_task_runner,
       scoped_refptr<base::SequencedTaskRunner> extension_cache_task_runner,
       scoped_refptr<base::SequencedTaskRunner>
           external_data_service_backend_task_runner,
       scoped_refptr<base::SequencedTaskRunner> io_task_runner,
       scoped_refptr<net::URLRequestContextGetter> request_context);
   virtual ~DeviceLocalAccountPolicyService();
 
   // Shuts down the service and prevents further policy fetches from the cloud.
   void Shutdown();
 
   // Initializes the cloud policy service connection.
   void Connect(DeviceManagementService* device_management_service);
 
   // Get the policy broker for a given |user_id|. Returns NULL if that |user_id|
   // does not belong to an existing device-local account.
   DeviceLocalAccountPolicyBroker* GetBrokerForUser(const std::string& user_id);
 
   // Indicates whether policy has been successfully fetched for the given
   // |user_id|.
   bool IsPolicyAvailableForUser(const std::string& user_id);
 
+  scoped_refptr<net::URLRequestContextGetter> request_context() const;
+
   void AddObserver(Observer* observer);
   void RemoveObserver(Observer* observer);
 
   // CloudPolicyStore::Observer:
   virtual void OnStoreLoaded(CloudPolicyStore* store) OVERRIDE;
   virtual void OnStoreError(CloudPolicyStore* store) OVERRIDE;
 
  private:
   typedef std::map<std::string, DeviceLocalAccountPolicyBroker*>
       PolicyBrokerMap;
@@ skipping 50 matching lines @@
   // are not trusted yet.
   bool waiting_for_cros_settings_;
 
   // Orphaned extension caches are removed at startup. This tracks the status of
   // that process.
   enum OrphanCacheDeletionState {
     NOT_STARTED,
     IN_PROGRESS,
     DONE,
   };
   OrphanCacheDeletionState orphan_cache_deletion_state_;

[bartfab (slow), 2014/06/20 09:17:25]

Nit: The type, member name and comment need to be updated to clarify that they
refer to the extensions cache only.

[Joao da Silva, 2014/06/20 11:48:46]

Done.

 
   // Account IDs whose extension cache directories are busy, either because a
   // broker for the account has not shut down completely yet or because the
   // directory is being deleted.
   std::set<std::string> busy_extension_cache_directories_;
 
   const scoped_refptr<base::SequencedTaskRunner> store_background_task_runner_;
   const scoped_refptr<base::SequencedTaskRunner> extension_cache_task_runner_;
 
   scoped_ptr<DeviceLocalAccountExternalDataService> external_data_service_;
 
   scoped_refptr<net::URLRequestContextGetter> request_context_;
 
   const scoped_ptr<chromeos::CrosSettings::ObserverSubscription>
       local_accounts_subscription_;
 
+  // Path to the directory that contains the cached policies for components

[bartfab (slow), 2014/06/20 09:17:25]

Nit: s/policies/policy/

[Joao da Silva, 2014/06/20 11:48:45]

Done.

+  // for device local accounts.

[bartfab (slow), 2014/06/20 09:17:25]

Nit: s/device local/device-local/

[Joao da Silva, 2014/06/20 11:48:45]

Done.

+  base::FilePath component_policy_cache_root_;
+
   base::WeakPtrFactory<DeviceLocalAccountPolicyService> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(DeviceLocalAccountPolicyService);
 };
 
 }  // namespace policy
 
 #endif  // CHROME_BROWSER_CHROMEOS_POLICY_DEVICE_LOCAL_ACCOUNT_POLICY_SERVICE_H_