cc: Pass scaled bounds to debug border quads for drawing.

cc: Pass scaled bounds to debug border quads for drawing.

As PictureLayerImpl now uses scaled rects, bounds and transforms for setting up
SQS, we need to pass the same to debug border quads too.
BUG=384623
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278810

[sohanjg, 2014-06-19 09:10:45]

Please take a look.
Thanks.

[danakj, 2014-06-19 16:01:15]

LG but let's avoid adding an overload of the method. Just change all the
callsites to pass in content_bounds().

https://codereview.chromium.org/341023003/diff/1/cc/layers/layer_impl.h
File cc/layers/layer_impl.h (right):

https://codereview.chromium.org/341023003/diff/1/cc/layers/layer_impl.h#newco...
cc/layers/layer_impl.h:541: const SharedQuadState* shared_quad_state,
Remove this version of the method, ie have the layer always pass in the bounds.

[sohanjg, 2014-06-20 07:28:30]

Please take a look.
Thanks.

https://codereview.chromium.org/341023003/diff/1/cc/layers/layer_impl.h
File cc/layers/layer_impl.h (right):

https://codereview.chromium.org/341023003/diff/1/cc/layers/layer_impl.h#newco...
cc/layers/layer_impl.h:541: const SharedQuadState* shared_quad_state,
On 2014/06/19 16:01:14, danakj wrote:
> Remove this version of the method, ie have the layer always pass in the
bounds.

Done.

[danakj, 2014-06-20 16:05:39]

I take it you ran this and verified it fixes the layer border to be correct? :)
I was guessing this was the cause but you never know..

LGTM given the above.

[danakj, 2014-06-20 16:15:34]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-06-20 16:17:59]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sohan.jyoti@samsung.com/341023003/20001

[commit-bot: I haz the power, 2014-06-20 18:11:18]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/8...)

[commit-bot: I haz the power, 2014-06-20 18:19:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-20 18:19:55]

Try jobs failed on following builders:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/8...)

[danakj, 2014-06-20 18:22:29]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-06-20 18:23:40]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sohan.jyoti@samsung.com/341023003/20001

[commit-bot: I haz the power, 2014-06-20 19:06:12]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/8...)

[commit-bot: I haz the power, 2014-06-20 19:17:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-20 19:17:30]

Try jobs failed on following builders:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/8...)

[danakj, 2014-06-20 19:26:41]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-06-20 19:27:53]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sohan.jyoti@samsung.com/341023003/20001

[commit-bot: I haz the power, 2014-06-20 20:20:35]

Change committed as 278810

[sohanjg, 2015-11-18 09:36:48]

Description was changed from

==========
cc: Pass scaled bounds to debug border quads for drawing.

As PictureLayerImpl now uses scaled rects, bounds and transforms for setting up
SQS, we need to pass the same to debug border quads too.
BUG=384623

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278810
==========

to

==========
cc: Pass scaled bounds to debug border quads for drawing.

As PictureLayerImpl now uses scaled rects, bounds and transforms for setting up
SQS, we need to pass the same to debug border quads too.
BUG=384623

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278810
==========