content/browser/loader/buffered_resource_handler.cc - Issue 340953006: Fix some DCHECKS when using BrowserPlugin for extension mime type handlers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/loader/buffered_resource_handler.cc

Issue 340953006: Fix some DCHECKS when using BrowserPlugin for extension mime type handlers (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Code review fixes Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/loader/buffered_resource_handler.cc

diff --git a/content/browser/loader/buffered_resource_handler.cc b/content/browser/loader/buffered_resource_handler.cc

index f609cbfbef752167b0ad743768d482eff9ac9c65..8fb8c5d4484c1d4ef473ed551a3dfe5613598ec7 100644

--- a/content/browser/loader/buffered_resource_handler.cc

+++ b/content/browser/loader/buffered_resource_handler.cc

@@ -386,7 +386,7 @@ bool BufferedResourceHandler::UseAlternateNextHandler(

scoped_refptr<net::IOBuffer> buf;

int size = 0;

- next_handler_->OnWillRead(&buf, &size, payload_for_old_handler.length());

+ next_handler_->OnWillRead(&buf, &size, -1);

CHECK_GE(size, static_cast<int>(payload_for_old_handler.length()));

memcpy(buf->data(), payload_for_old_handler.c_str(),

« no previous file with comments | « chrome/browser/extensions/plugin_manager.cc ('k') | no next file » | no next file with comments »