Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 340953004: Add user_prefs and visitedlink components to GN build. (Closed)

Created:
6 years, 6 months ago by brettw
Modified:
6 years, 6 months ago
Reviewers:
jamesr
CC:
chromium-reviews, darin-cc_chromium.org, jam
Project:
chromium
Visibility:
Public.

Description

Add user_prefs and visitedlink components to GN build. This doesn't hook up visitedlink_renderer since it depends on blink. BUG= R=jamesr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278404

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -0 lines) Patch
M BUILD.gn View 2 chunks +7 lines, -0 lines 0 comments Download
A components/user_prefs/BUILD.gn View 1 chunk +20 lines, -0 lines 0 comments Download
A components/visitedlink/browser/BUILD.gn View 1 chunk +21 lines, -0 lines 0 comments Download
A components/visitedlink/common/BUILD.gn View 1 chunk +21 lines, -0 lines 0 comments Download
A components/visitedlink/renderer/BUILD.gn View 1 chunk +20 lines, -0 lines 0 comments Download
M content/public/browser/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
brettw
6 years, 6 months ago (2014-06-19 00:06:11 UTC) #1
jamesr
lgtm
6 years, 6 months ago (2014-06-19 00:08:28 UTC) #2
brettw
The CQ bit was checked by brettw@chromium.org
6 years, 6 months ago (2014-06-19 05:03:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/340953004/1
6 years, 6 months ago (2014-06-19 05:05:09 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-19 13:06:42 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/74783)
6 years, 6 months ago (2014-06-19 13:06:43 UTC) #6
brettw
6 years, 6 months ago (2014-06-19 16:52:32 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 manually as r278404.

Powered by Google App Engine
This is Rietveld 408576698