Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: Source/modules/serviceworkers/ServiceWorker.idl

Issue 340943002: ServiceWorker: Update IDLs to use ScalarValueString (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Add URLs and one real test case Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/serviceworkers/Response.idl ('k') | Source/modules/serviceworkers/ServiceWorkerClients.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/serviceworkers/ServiceWorker.idl
diff --git a/Source/modules/serviceworkers/ServiceWorker.idl b/Source/modules/serviceworkers/ServiceWorker.idl
index e1033e4840bb2d0ecfd49bddb2d93c6bf055a13b..b9a2bddfd239b3c3b760f0fed680d50d03efde2e 100644
--- a/Source/modules/serviceworkers/ServiceWorker.idl
+++ b/Source/modules/serviceworkers/ServiceWorker.idl
@@ -27,6 +27,8 @@
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
+
+// https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#service-worker-interface
[
ActiveDOMObject,
RuntimeEnabled=ServiceWorker
@@ -35,8 +37,9 @@
// FIXME: Should inherit this from Worker.
[Custom, RaisesException] void postMessage(SerializedScriptValue message, optional MessagePort[] messagePorts);
- readonly attribute DOMString scope;
- readonly attribute DOMString url;
+ readonly attribute ScalarValueString scope;
+ readonly attribute ScalarValueString url;
+ // FIXME: Should be ServiceWorkerState enum, not DOMString.
readonly attribute DOMString state;
attribute EventHandler onstatechange;
};
« no previous file with comments | « Source/modules/serviceworkers/Response.idl ('k') | Source/modules/serviceworkers/ServiceWorkerClients.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698