Source/bindings/scripts/v8_interface.py - Issue 340943002: ServiceWorker: Update IDLs to use ScalarValueString

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_interface.py

Issue 340943002: ServiceWorker: Update IDLs to use ScalarValueString (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Add URLs and one real test case Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/scripts/v8_interface.py

diff --git a/Source/bindings/scripts/v8_interface.py b/Source/bindings/scripts/v8_interface.py

index 677827bd94a593a6b6b73384e973bc4de925c688..0635378194ea1b90a8271590796472fb420932d5 100644

--- a/Source/bindings/scripts/v8_interface.py

+++ b/Source/bindings/scripts/v8_interface.py

@@ -761,9 +761,14 @@ def resolution_tests_methods(effective_overloads):

# types at position i of its type list,

# • DOMString

# • an enumeration type

+ # * ByteString

+ # Blink: ScalarValueString is a pending Web IDL addition

try:

method = next(method for idl_type, method in idl_types_methods

- if idl_type.name == 'String' or idl_type.is_enum)

+ if idl_type.name in ('String',

+ 'ByteString',

+ 'ScalarValueString') or

+ idl_type.is_enum)

yield 'true', method

except StopIteration:

pass