Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 340913003: Move images from drawable to drawable-mdpi. (Closed)

Created:
6 years, 6 months ago by newt (away)
Modified:
6 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, dcheng
Project:
chromium
Visibility:
Public.

Description

Move images from drawable to drawable-mdpi. The benefits: Android lint can find resources that don't exist in all resolutions, it's clearer what resolution these images are, and the drawable folder is neater as well. The build output after this change is identical, thanks to recent build changes (https://codereview.chromium.org/321463002) as well as the method MoveImagesToNonMdpiFolders() in package_resources.py. BUG=289843 R=dtrainor@chromium.org, tedchoc@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278745

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -0 lines) Patch
D chrome/android/java/res/drawable-ldrtl-hdpi/warning.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-ldrtl-xhdpi/infobar_blocked_popups.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-ldrtl-xhdpi/warning.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-ldrtl/infobar_blocked_popups.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-ldrtl/warning.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-mdpi/btn_back_disabled.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-mdpi/btn_back_normal.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-mdpi/btn_back_pressed.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-mdpi/btn_forward_disabled.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-mdpi/btn_forward_normal.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-mdpi/btn_forward_pressed.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-mdpi/btn_star_filled.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-mdpi/btn_star_normal.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-mdpi/btn_star_pressed.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-mdpi/dismiss.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-mdpi/globe_favicon.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-mdpi/globe_incognito_favicon.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-mdpi/infobar_autofill.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-mdpi/infobar_autologin.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-mdpi/infobar_blocked_popups.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-mdpi/infobar_button_normal_floating_enabled.9.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-mdpi/infobar_button_normal_floating_pressed.9.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-mdpi/infobar_button_warning_floating_enabled.9.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-mdpi/infobar_button_warning_floating_pressed.9.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-mdpi/infobar_camera.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-mdpi/infobar_cookie.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-mdpi/infobar_desktop_notifications.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-mdpi/infobar_didyoumean.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-mdpi/infobar_geolocation.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-mdpi/infobar_microphone.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-mdpi/infobar_multiple_downloads.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-mdpi/infobar_plugin.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-mdpi/infobar_plugin_crashed.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-mdpi/infobar_protected_media_identifier.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-mdpi/infobar_restore.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-mdpi/infobar_savepassword.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-mdpi/infobar_theme.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-mdpi/infobar_translate.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-mdpi/infobar_update_uma.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-mdpi/infobar_warning.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-mdpi/ntp_toolbar_button_background_pressed_img.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-mdpi/ntp_toolbar_button_background_selected_img.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-mdpi/ntp_toolbar_button_background_selected_pressed_img.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-mdpi/pageinfo_bad.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-mdpi/pageinfo_enterprise_managed.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-mdpi/pageinfo_good.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-mdpi/pageinfo_info.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-mdpi/pageinfo_warning_minor.png View Binary file 0 comments Download
A + chrome/android/java/res/drawable-mdpi/warning.png View Binary file 0 comments Download
D chrome/android/java/res/drawable/btn_back_disabled.png View Binary file 0 comments Download
D chrome/android/java/res/drawable/btn_back_normal.png View Binary file 0 comments Download
D chrome/android/java/res/drawable/btn_back_pressed.png View Binary file 0 comments Download
D chrome/android/java/res/drawable/btn_forward_disabled.png View Binary file 0 comments Download
D chrome/android/java/res/drawable/btn_forward_normal.png View Binary file 0 comments Download
D chrome/android/java/res/drawable/btn_forward_pressed.png View Binary file 0 comments Download
D chrome/android/java/res/drawable/btn_star_filled.png View Binary file 0 comments Download
D chrome/android/java/res/drawable/btn_star_normal.png View Binary file 0 comments Download
D chrome/android/java/res/drawable/btn_star_pressed.png View Binary file 0 comments Download
D chrome/android/java/res/drawable/dismiss.png View Binary file 0 comments Download
D chrome/android/java/res/drawable/globe_favicon.png View Binary file 0 comments Download
D chrome/android/java/res/drawable/globe_incognito_favicon.png View Binary file 0 comments Download
D chrome/android/java/res/drawable/infobar_autofill.png View Binary file 0 comments Download
D chrome/android/java/res/drawable/infobar_autologin.png View Binary file 0 comments Download
D chrome/android/java/res/drawable/infobar_blocked_popups.png View Binary file 0 comments Download
D chrome/android/java/res/drawable/infobar_button_normal_floating_enabled.9.png View Binary file 0 comments Download
D chrome/android/java/res/drawable/infobar_button_normal_floating_pressed.9.png View Binary file 0 comments Download
D chrome/android/java/res/drawable/infobar_button_warning_floating_enabled.9.png View Binary file 0 comments Download
D chrome/android/java/res/drawable/infobar_button_warning_floating_pressed.9.png View Binary file 0 comments Download
D chrome/android/java/res/drawable/infobar_camera.png View Binary file 0 comments Download
D chrome/android/java/res/drawable/infobar_cookie.png View Binary file 0 comments Download
D chrome/android/java/res/drawable/infobar_desktop_notifications.png View Binary file 0 comments Download
D chrome/android/java/res/drawable/infobar_didyoumean.png View Binary file 0 comments Download
D chrome/android/java/res/drawable/infobar_geolocation.png View Binary file 0 comments Download
D chrome/android/java/res/drawable/infobar_microphone.png View Binary file 0 comments Download
D chrome/android/java/res/drawable/infobar_multiple_downloads.png View Binary file 0 comments Download
D chrome/android/java/res/drawable/infobar_plugin.png View Binary file 0 comments Download
D chrome/android/java/res/drawable/infobar_plugin_crashed.png View Binary file 0 comments Download
D chrome/android/java/res/drawable/infobar_protected_media_identifier.png View Binary file 0 comments Download
D chrome/android/java/res/drawable/infobar_restore.png View Binary file 0 comments Download
D chrome/android/java/res/drawable/infobar_savepassword.png View Binary file 0 comments Download
D chrome/android/java/res/drawable/infobar_theme.png View Binary file 0 comments Download
D chrome/android/java/res/drawable/infobar_translate.png View Binary file 0 comments Download
D chrome/android/java/res/drawable/infobar_update_uma.png View Binary file 0 comments Download
D chrome/android/java/res/drawable/infobar_warning.png View Binary file 0 comments Download
D chrome/android/java/res/drawable/ntp_toolbar_button_background_pressed_img.png View Binary file 0 comments Download
D chrome/android/java/res/drawable/ntp_toolbar_button_background_selected_img.png View Binary file 0 comments Download
D chrome/android/java/res/drawable/ntp_toolbar_button_background_selected_pressed_img.png View Binary file 0 comments Download
D chrome/android/java/res/drawable/pageinfo_bad.png View Binary file 0 comments Download
D chrome/android/java/res/drawable/pageinfo_enterprise_managed.png View Binary file 0 comments Download
D chrome/android/java/res/drawable/pageinfo_good.png View Binary file 0 comments Download
D chrome/android/java/res/drawable/pageinfo_info.png View Binary file 0 comments Download
D chrome/android/java/res/drawable/pageinfo_warning_minor.png View Binary file 0 comments Download
D chrome/android/java/res/drawable/warning.png View Binary file 0 comments Download
A + content/public/android/java/res/drawable-mdpi/bubble.9.png View Binary file 0 comments Download
A + content/public/android/java/res/drawable-mdpi/bubble_arrow_up.png View Binary file 0 comments Download
A + content/public/android/java/res/drawable-mdpi/ic_menu_search_holo_light.png View Binary file 0 comments Download
A + content/public/android/java/res/drawable-mdpi/ic_menu_share_holo_light.png View Binary file 0 comments Download
A + content/public/android/java/res/drawable-mdpi/ondemand_overlay.9.png View Binary file 0 comments Download
A + content/public/android/java/res/drawable-mdpi/pageinfo_warning_major.png View Binary file 0 comments Download
D content/public/android/java/res/drawable/bubble.9.png View Binary file 0 comments Download
D content/public/android/java/res/drawable/bubble_arrow_up.png View Binary file 0 comments Download
D content/public/android/java/res/drawable/ic_menu_search_holo_light.png View Binary file 0 comments Download
D content/public/android/java/res/drawable/ic_menu_share_holo_light.png View Binary file 0 comments Download
D content/public/android/java/res/drawable/ondemand_overlay.9.png View Binary file 0 comments Download
D content/public/android/java/res/drawable/pageinfo_warning_major.png View Binary file 0 comments Download
A + ui/android/java/res/drawable-mdpi/color_picker_advanced_select_handle.png View Binary file 0 comments Download
A + ui/android/java/res/drawable-mdpi/dropdown_popup_background_down.9.png View Binary file 0 comments Download
A + ui/android/java/res/drawable-mdpi/dropdown_popup_background_up.9.png View Binary file 0 comments Download
D ui/android/java/res/drawable/color_picker_advanced_select_handle.png View Binary file 0 comments Download
D ui/android/java/res/drawable/dropdown_popup_background_down.9.png View Binary file 0 comments Download
D ui/android/java/res/drawable/dropdown_popup_background_up.9.png View Binary file 0 comments Download

Messages

Total messages: 5 (0 generated)
newt (away)
PTAL A few images haven't moved yet, pending new or updated assets.
6 years, 6 months ago (2014-06-18 22:11:08 UTC) #1
David Trainor- moved to gerrit
lgtm
6 years, 6 months ago (2014-06-18 22:23:37 UTC) #2
newt (away)
+tedchoc for content/public/android OWNERS
6 years, 6 months ago (2014-06-19 17:23:25 UTC) #3
Ted C
On 2014/06/19 17:23:25, newt wrote: > +tedchoc for content/public/android OWNERS lgtm
6 years, 6 months ago (2014-06-19 17:27:48 UTC) #4
newt (away)
6 years, 6 months ago (2014-06-20 17:27:35 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 manually as r278745 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698