Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: media/cast/video_sender/video_sender.h

Issue 340903003: [Cast] Halt AudioSender transmission when too many frames are in-flight. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/cast/audio_sender/audio_sender.cc ('k') | media/cast/video_sender/video_sender.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/cast/video_sender/video_sender.h
diff --git a/media/cast/video_sender/video_sender.h b/media/cast/video_sender/video_sender.h
index 30066cbbf8025a4a535fd7bb7da2e69bc774beb6..cf8d27511c253ec39f1097f87e60e7a67c8f6602 100644
--- a/media/cast/video_sender/video_sender.h
+++ b/media/cast/video_sender/video_sender.h
@@ -76,15 +76,13 @@ class VideoSender : public RtcpSenderFeedback,
void ScheduleNextRtcpReport();
void SendRtcpReport(bool schedule_future_reports);
- // Schedule and execute periodic checks for re-sending frames. If no
+ // Schedule and execute periodic checks for re-sending packets. If no
// acknowledgements have been received for "too long," VideoSender will
- // speculatively re-send the frame just after |latest_acked_frame_id_| (the
- // whole frame). This is a last resort tactic to prevent the session from
+ // speculatively re-send certain packets of an unacked frame to kick-start
+ // re-transmission. This is a last resort tactic to prevent the session from
// getting stuck after a long outage.
void ScheduleNextResendCheck();
void ResendCheck();
-
- // Resend certain packets of an unacked frame to kick start re-transmission.
void ResendForKickstart();
// Returns true if there are too many frames in flight, as defined by the
@@ -169,10 +167,7 @@ class VideoSender : public RtcpSenderFeedback,
// This is a "good enough" mapping for finding the RTP timestamp associated
// with a video frame. The key is the lowest 8 bits of frame id (which is
- // what is sent via RTCP). This map is used for logging purposes. The only
- // time when this mapping will be incorrect is when it receives an ACK for a
- // old enough frame such that 8-bit wrap around has already occurred, which
- // should be pretty rare.
+ // what is sent via RTCP). This map is used for logging purposes.
RtpTimestamp frame_id_to_rtp_timestamp_[256];
// NOTE: Weak pointers must be invalidated before all other member variables.
« no previous file with comments | « media/cast/audio_sender/audio_sender.cc ('k') | media/cast/video_sender/video_sender.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698