Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issue 340903003: [Cast] Halt AudioSender transmission when too many frames are in-flight. (Closed)

Created:
6 years, 6 months ago by miu
Modified:
6 years, 6 months ago
Reviewers:
hubbe
CC:
chromium-reviews, hclam+watch_chromium.org, imcheng+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, pwestin+watch_google.com, feature-media-reviews_chromium.org, miu+watch_chromium.org, hubbe+watch_chromium.org, mikhal+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

[Cast] Halt AudioSender transmission when too many frames are in-flight. The approach here is to literally copy most of the logic in VideoSender over into AudioSender, since VideoSender already solves a number of transmission/re-transmission issues using heuristics that should work well for audio. (This also brings us much closer to being able to merge AudioSender and VideoSender into one implementation.) Testing: Confirmed correct halting and recovery behavior between cast_sender_app and cast_receiver_app (SIGSTOPP'ed and SIGCONT'ed each to simulate a temporary outage). Also tested a Chromium sender with a Chromecast receiver. BUG=380023 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278323

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+269 lines, -79 lines) Patch
M media/cast/audio_sender/audio_encoder.cc View 3 chunks +0 lines, -29 lines 0 comments Download
M media/cast/audio_sender/audio_sender.h View 4 chunks +89 lines, -12 lines 0 comments Download
M media/cast/audio_sender/audio_sender.cc View 9 chunks +175 lines, -28 lines 0 comments Download
M media/cast/video_sender/video_sender.h View 2 chunks +4 lines, -9 lines 0 comments Download
M media/cast/video_sender/video_sender.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
miu
hubbe: PTAL. For M-37, so need this very soon. Thanks!
6 years, 6 months ago (2014-06-18 20:46:40 UTC) #1
hubbe
lgtm
6 years, 6 months ago (2014-06-18 21:38:46 UTC) #2
miu
The CQ bit was checked by miu@chromium.org
6 years, 6 months ago (2014-06-18 21:59:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miu@chromium.org/340903003/1
6 years, 6 months ago (2014-06-18 22:01:22 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 11:22:22 UTC) #5
Message was sent while issue was closed.
Change committed as 278323

Powered by Google App Engine
This is Rietveld 408576698