Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 340893003: [safe browsing] Remove most filename storage in database object. (Closed)

Created:
6 years, 6 months ago by Scott Hess - ex-Googler
Modified:
6 years, 6 months ago
Reviewers:
mattm
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

[safe browsing] Remove most filename storage in database object. Instead of storing full copies of every backing file's path, re-generate the paths as needed. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278605

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase, minor whitespace nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -76 lines) Patch
M chrome/browser/safe_browsing/safe_browsing_database.h View 2 chunks +4 lines, -9 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_database.cc View 1 15 chunks +96 lines, -67 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Scott Hess - ex-Googler
https://codereview.chromium.org/340893003/diff/1/chrome/browser/safe_browsing/safe_browsing_database.cc File chrome/browser/safe_browsing/safe_browsing_database.cc (right): https://codereview.chromium.org/340893003/diff/1/chrome/browser/safe_browsing/safe_browsing_database.cc#newcode594 chrome/browser/safe_browsing/safe_browsing_database.cc:594: false); https://codereview.chromium.org/341553006/ adds this DeleteFile() line, so I'll land ...
6 years, 6 months ago (2014-06-18 22:07:17 UTC) #1
mattm
lgtm
6 years, 6 months ago (2014-06-18 22:43:59 UTC) #2
Scott Hess - ex-Googler
The CQ bit was checked by shess@chromium.org
6 years, 6 months ago (2014-06-19 19:39:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/340893003/20001
6 years, 6 months ago (2014-06-19 19:41:03 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 6 months ago (2014-06-20 01:00:11 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-20 05:04:04 UTC) #6
Message was sent while issue was closed.
Change committed as 278605

Powered by Google App Engine
This is Rietveld 408576698