Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 340883005: Add webapp hashes to whitelist for window shape API. (Closed)

Created:
6 years, 6 months ago by garykac
Modified:
6 years, 6 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, not at google - send to devlin
Project:
chromium
Visibility:
Public.

Description

Add webapp hashes to whitelist for window shape API. BUG=386324 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278759

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M chrome/common/extensions/api/_permission_features.json View 1 chunk +11 lines, -1 line 0 comments Download

Messages

Total messages: 17 (0 generated)
garykac
6 years, 6 months ago (2014-06-18 21:30:46 UTC) #1
garykac
+miket, since kalman seems to be OOF
6 years, 6 months ago (2014-06-19 20:51:46 UTC) #2
not at google - send to devlin
i'm around but i'm getting about 2 code reviews per hour right now. lgtm.
6 years, 6 months ago (2014-06-19 20:52:56 UTC) #3
garykac
On 2014/06/19 20:52:56, kalman wrote: > i'm around but i'm getting about 2 code reviews ...
6 years, 6 months ago (2014-06-19 21:02:35 UTC) #4
garykac1
The CQ bit was checked by garykac@google.com
6 years, 6 months ago (2014-06-19 21:02:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/garykac@chromium.org/340883005/1
6 years, 6 months ago (2014-06-19 21:04:16 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-19 21:24:42 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/85544) linux_chromium_chromeos_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_clang_dbg/builds/24525)
6 years, 6 months ago (2014-06-19 21:24:43 UTC) #8
garykac1
The CQ bit was checked by garykac@google.com
6 years, 6 months ago (2014-06-19 21:30:13 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/garykac@chromium.org/340883005/1
6 years, 6 months ago (2014-06-19 21:32:04 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 6 months ago (2014-06-19 21:56:35 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-19 22:06:26 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/85573)
6 years, 6 months ago (2014-06-19 22:06:27 UTC) #13
garykac
The CQ bit was checked by garykac@chromium.org
6 years, 6 months ago (2014-06-20 16:43:47 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/garykac@chromium.org/340883005/1
6 years, 6 months ago (2014-06-20 16:45:51 UTC) #15
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 6 months ago (2014-06-20 16:55:20 UTC) #16
commit-bot: I haz the power
6 years, 6 months ago (2014-06-20 17:59:04 UTC) #17
Message was sent while issue was closed.
Change committed as 278759

Powered by Google App Engine
This is Rietveld 408576698