content/common/OWNERS - Issue 340863002: Add danakj as OWNERS for content/common/cc_messages_unittest.cc

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/common/OWNERS

Issue 340863002: Add danakj as OWNERS for content/common/cc_messages_unittest.cc (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 # For Linux sandboxing	1 # For Linux sandboxing

2 cevans@chromium.org	2 cevans@chromium.org

3 jln@chromium.org	3 jln@chromium.org

4	4

5 # For security review of sandboxes	5 # For security review of sandboxes

6 per-file sandbox_win.cc=set noparent	6 per-file sandbox_win.cc=set noparent

7 per-file sandbox_win.cc=jschuh@chromium.org	7 per-file sandbox_win.cc=jschuh@chromium.org

8 per-file sandbox_win.cc=cpu@chromium.org	8 per-file sandbox_win.cc=cpu@chromium.org

9	9

10 # Mac Sandbox.	10 # Mac Sandbox.

(...skipping 32 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
43 per-file param_traits.h=tsepez@chromium.org	43 per-file param_traits.h=tsepez@chromium.org

44	44

45 # Accessibility	45 # Accessibility

46 per-file accessibility_node_data.*=dmazzoni@chromium.org	46 per-file accessibility_node_data.*=dmazzoni@chromium.org

47 per-file accessibility_node_data.*=dtseng@chromium.org	47 per-file accessibility_node_data.*=dtseng@chromium.org

48	48

49 # WebSocket	49 # WebSocket

50 per-file websocket.*=ricea@chromium.org	50 per-file websocket.*=ricea@chromium.org

51 per-file websocket.*=tyoshino@chromium.org	51 per-file websocket.*=tyoshino@chromium.org

52 per-file websocket.*=yhirano@chromium.org	52 per-file websocket.*=yhirano@chromium.org

	53

	54 # Compositor

	55 per-file cc_messages*=danakj@chromium.org
	jam 2014/06/18 17:14:58 all IPC message files need a person from the secur all IPC message files need a person from the security review to sign off on (see the comment on line 21). danakj 2014/06/18 17:28:00 I was mimicing the WebSocket above. I can change t Show quoted text On 2014/06/18 17:14:58, jam wrote: > all IPC message files need a person from the security review to sign off on (see > the comment on line 21). I was mimicing the WebSocket above. I can change this to .cc and _unittest.cc if you prefer? Was not trying to sidestep the security team rules on the .h, I assumed this worked out from the WebSocket rule, I guess not? jam 2014/06/18 18:04:16 The websocket exception is for websocket., which Show quoted text On 2014/06/18 17:28:00, danakj wrote: > On 2014/06/18 17:14:58, jam wrote: > > all IPC message files need a person from the security review to sign off on > (see > > the comment on line 21). > > I was mimicing the WebSocket above. I can change this to .cc and _unittest.cc if > you prefer? The websocket exception is for websocket., which won't cover websocket_messages.h (i.e. security team still has to review that IPC file) cc_messages.cc has the IPC param traits, which is also something that security team wants to review. Show quoted text > Was not trying to sidestep the security team rules on the .h, I > assumed this worked out from the WebSocket rule, I guess not? no problem, I didn't mean to imply that you're trying to sidestep that. danakj 2014/06/18 18:08:21 Is it? There is no rule for that today. We have to Show quoted text On 2014/06/18 18:04:16, jam wrote: > cc_messages.cc has the IPC param traits, which is also something that security > team wants to review. Is it? There is no rule for that today. We have to change the header file to add a new thing to a message.
OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »