Files.app: Create unit tests for MetadataCache.

Files.app: Create unit tests for MetadataCache.

BUG=386553
TEST=run the test

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278736

[hirono, 2014-06-19 12:04:57]

PTAL the CL? Thank you!

[yoshiki, 2014-06-20 05:02:48]

sorry for late. lgtm with nit.

https://codereview.chromium.org/340843005/diff/1/chrome/test/data/file_manage...
File chrome/test/data/file_manager/unit_tests/metadata_cache_unittest.js
(right):

https://codereview.chromium.org/340843005/diff/1/chrome/test/data/file_manage...
chrome/test/data/file_manager/unit_tests/metadata_cache_unittest.js:39: * Short
hand for the metadataCache.get.
nit: missing @param's

https://codereview.chromium.org/340843005/diff/1/chrome/test/data/file_manage...
chrome/test/data/file_manager/unit_tests/metadata_cache_unittest.js:41: function
get(entries, type) {
I think 'get' is too short. 'getMetadata' is more moderate.

https://codereview.chromium.org/340843005/diff/1/chrome/test/data/file_manage...
chrome/test/data/file_manager/unit_tests/metadata_cache_unittest.js:70: *
Confirms metadata is cached for the same entry.
nit: missing @param

https://codereview.chromium.org/340843005/diff/1/chrome/test/data/file_manage...
chrome/test/data/file_manager/unit_tests/metadata_cache_unittest.js:96: *
Confirms metadata is not cached for different entries.
nit: missing @param

[hirono, 2014-06-20 10:01:06]

Thank you!

https://codereview.chromium.org/340843005/diff/1/chrome/test/data/file_manage...
File chrome/test/data/file_manager/unit_tests/metadata_cache_unittest.js
(right):

https://codereview.chromium.org/340843005/diff/1/chrome/test/data/file_manage...
chrome/test/data/file_manager/unit_tests/metadata_cache_unittest.js:39: * Short
hand for the metadataCache.get.
On 2014/06/20 05:02:47, yoshiki wrote:
> nit: missing @param's

Done.

https://codereview.chromium.org/340843005/diff/1/chrome/test/data/file_manage...
chrome/test/data/file_manager/unit_tests/metadata_cache_unittest.js:41: function
get(entries, type) {
On 2014/06/20 05:02:47, yoshiki wrote:
> I think 'get' is too short. 'getMetadata' is more moderate.

Done.

https://codereview.chromium.org/340843005/diff/1/chrome/test/data/file_manage...
chrome/test/data/file_manager/unit_tests/metadata_cache_unittest.js:70: *
Confirms metadata is cached for the same entry.
On 2014/06/20 05:02:47, yoshiki wrote:
> nit: missing @param

Done.

https://codereview.chromium.org/340843005/diff/1/chrome/test/data/file_manage...
chrome/test/data/file_manager/unit_tests/metadata_cache_unittest.js:96: *
Confirms metadata is not cached for different entries.
On 2014/06/20 05:02:47, yoshiki wrote:
> nit: missing @param

Done.

[hirono, 2014-06-20 10:01:08]

The CQ bit was checked by hirono@chromium.org

[commit-bot: I haz the power, 2014-06-20 10:02:29]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hirono@chromium.org/340843005/20001

[commit-bot: I haz the power, 2014-06-20 17:15:29]

Change committed as 278736