Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(815)

Unified Diff: Source/core/inspector/InspectorPageAgent.cpp

Issue 340803002: DevTools: fix for test inspector-protocol/page/enable-disable.html (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: problem fixed Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/inspector-protocol/page/enable-disable-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/inspector/InspectorPageAgent.cpp
diff --git a/Source/core/inspector/InspectorPageAgent.cpp b/Source/core/inspector/InspectorPageAgent.cpp
index 49d2fb7afc980b926cdb1338848977769cdaf5fb..c67784bce262ba6dfe6ed77c4f7e71d6148994e4 100644
--- a/Source/core/inspector/InspectorPageAgent.cpp
+++ b/Source/core/inspector/InspectorPageAgent.cpp
@@ -418,7 +418,8 @@ void InspectorPageAgent::disable(ErrorString*)
setShowDebugBorders(0, false);
setShowFPSCounter(0, false);
setEmulatedMedia(0, String());
- setContinuousPaintingEnabled(0, false);
+ if (m_state->getBoolean(PageAgentState::pageAgentContinuousPaintingEnabled))
+ setContinuousPaintingEnabled(0, false);
setShowScrollBottleneckRects(0, false);
setShowViewportSizeOnResize(0, false, 0);
@@ -427,14 +428,14 @@ void InspectorPageAgent::disable(ErrorString*)
m_state->setBoolean(PageAgentState::touchEventEmulationEnabled, false);
}
- if (!deviceMetricsChanged(false, 0, 0, 0, false, false, 1, false))
+ if (!deviceMetricsChanged(false, 0, 0, 1, false, false, 1, false))
return;
// When disabling the agent, reset the override values if necessary.
- updateViewMetrics(false, 0, 0, 0, false, false, m_embedderFontScaleFactor, m_embedderTextAutosizingEnabled);
+ updateViewMetrics(false, 0, 0, 1, false, false, m_embedderFontScaleFactor, m_embedderTextAutosizingEnabled);
m_state->setLong(PageAgentState::pageAgentScreenWidthOverride, 0);
m_state->setLong(PageAgentState::pageAgentScreenHeightOverride, 0);
- m_state->setDouble(PageAgentState::pageAgentDeviceScaleFactorOverride, 0);
+ m_state->setDouble(PageAgentState::pageAgentDeviceScaleFactorOverride, 1);
m_state->setBoolean(PageAgentState::pageAgentEmulateViewport, false);
m_state->setBoolean(PageAgentState::pageAgentFitWindow, false);
m_state->setDouble(PageAgentState::fontScaleFactor, 1);
@@ -741,7 +742,14 @@ bool InspectorPageAgent::deviceMetricsChanged(bool enabled, int width, int heigh
double currentFontScaleFactor = m_state->getDouble(PageAgentState::fontScaleFactor, 1);
bool currentTextAutosizing = m_state->getBoolean(PageAgentState::pageAgentTextAutosizingOverride);
- return enabled != currentEnabled || width != currentWidth || height != currentHeight || deviceScaleFactor != currentDeviceScaleFactor || emulateViewport != currentEmulateViewport || fitWindow != currentFitWindow || fontScaleFactor != currentFontScaleFactor || textAutosizing != currentTextAutosizing;
+ return enabled != currentEnabled
+ || width != currentWidth
+ || height != currentHeight
+ || deviceScaleFactor != currentDeviceScaleFactor
+ || emulateViewport != currentEmulateViewport
+ || fitWindow != currentFitWindow
+ || fontScaleFactor != currentFontScaleFactor
+ || textAutosizing != currentTextAutosizing;
}
void InspectorPageAgent::setShowPaintRects(ErrorString*, bool show)
« no previous file with comments | « LayoutTests/inspector-protocol/page/enable-disable-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698