Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 340803002: DevTools: fix for test inspector-protocol/page/enable-disable.html (Closed)

Created:
6 years, 6 months ago by loislo
Modified:
6 years, 6 months ago
Reviewers:
caseq, dgozman, yurys, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: fix for test inspector-protocol/page/enable-disable.html BUG=316349 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176447

Patch Set 1 #

Patch Set 2 : race was removed #

Total comments: 4

Patch Set 3 : comments addressed #

Patch Set 4 : problem fixed #

Total comments: 2

Patch Set 5 : comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -17 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/inspector-protocol/resources/protocol-test.html View 1 2 3 3 chunks +10 lines, -0 lines 0 comments Download
M LayoutTests/inspector-protocol/page/enable-disable.html View 1 2 3 1 chunk +37 lines, -11 lines 0 comments Download
M LayoutTests/inspector-protocol/page/enable-disable-expected.txt View 1 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorPageAgent.cpp View 1 2 3 4 2 chunks +11 lines, -3 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
loislo
6 years, 6 months ago (2014-06-18 12:21:36 UTC) #1
yurys
lgtm
6 years, 6 months ago (2014-06-18 12:29:05 UTC) #2
loislo
The CQ bit was checked by loislo@chromium.org
6 years, 6 months ago (2014-06-18 12:30:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/loislo@chromium.org/340803002/1
6 years, 6 months ago (2014-06-18 12:31:17 UTC) #4
loislo
The CQ bit was unchecked by loislo@chromium.org
6 years, 6 months ago (2014-06-18 13:27:08 UTC) #5
loislo
The CQ bit was checked by loislo@chromium.org
6 years, 6 months ago (2014-06-18 13:58:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/loislo@chromium.org/340803002/20001
6 years, 6 months ago (2014-06-18 13:59:07 UTC) #7
loislo
The CQ bit was unchecked by loislo@chromium.org
6 years, 6 months ago (2014-06-18 13:59:53 UTC) #8
yurys
https://codereview.chromium.org/340803002/diff/20001/LayoutTests/inspector-protocol/page/enable-disable.html File LayoutTests/inspector-protocol/page/enable-disable.html (right): https://codereview.chromium.org/340803002/diff/20001/LayoutTests/inspector-protocol/page/enable-disable.html#newcode42 LayoutTests/inspector-protocol/page/enable-disable.html:42: "ScheduleStyleRecalculation", This event will be followed by Layout event ...
6 years, 6 months ago (2014-06-18 14:06:12 UTC) #9
loislo
https://codereview.chromium.org/340803002/diff/20001/LayoutTests/inspector-protocol/page/enable-disable.html File LayoutTests/inspector-protocol/page/enable-disable.html (right): https://codereview.chromium.org/340803002/diff/20001/LayoutTests/inspector-protocol/page/enable-disable.html#newcode42 LayoutTests/inspector-protocol/page/enable-disable.html:42: "ScheduleStyleRecalculation", On 2014/06/18 14:06:12, yurys wrote: > This event ...
6 years, 6 months ago (2014-06-18 14:22:01 UTC) #10
loislo
problem has been fixed. PTAL
6 years, 6 months ago (2014-06-18 16:58:52 UTC) #11
loislo
6 years, 6 months ago (2014-06-18 16:59:06 UTC) #12
dgozman
https://codereview.chromium.org/340803002/diff/60001/Source/core/inspector/InspectorPageAgent.cpp File Source/core/inspector/InspectorPageAgent.cpp (right): https://codereview.chromium.org/340803002/diff/60001/Source/core/inspector/InspectorPageAgent.cpp#newcode739 Source/core/inspector/InspectorPageAgent.cpp:739: double currentDeviceScaleFactor = m_state->getDouble(PageAgentState::pageAgentDeviceScaleFactorOverride, 1); Change this to zero ...
6 years, 6 months ago (2014-06-18 17:04:36 UTC) #13
loislo
https://codereview.chromium.org/340803002/diff/60001/Source/core/inspector/InspectorPageAgent.cpp File Source/core/inspector/InspectorPageAgent.cpp (right): https://codereview.chromium.org/340803002/diff/60001/Source/core/inspector/InspectorPageAgent.cpp#newcode739 Source/core/inspector/InspectorPageAgent.cpp:739: double currentDeviceScaleFactor = m_state->getDouble(PageAgentState::pageAgentDeviceScaleFactorOverride, 1); On 2014/06/18 17:04:36, dgozman ...
6 years, 6 months ago (2014-06-18 17:12:21 UTC) #14
loislo
The CQ bit was checked by loislo@chromium.org
6 years, 6 months ago (2014-06-18 17:16:33 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/loislo@chromium.org/340803002/80001
6 years, 6 months ago (2014-06-18 17:17:36 UTC) #16
pfeldman
lgtm
6 years, 6 months ago (2014-06-18 18:23:50 UTC) #17
commit-bot: I haz the power
6 years, 6 months ago (2014-06-18 19:53:45 UTC) #18
Message was sent while issue was closed. 
Change committed as 176447

Powered by Google App Engine
This is Rietveld 408576698