sdk/lib/_internal/compiler/implementation/js_backend/type_variable_handler.dart - Issue 340783011: Take inheritance into account when computing the elements accessible by mirrors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/js_backend/type_variable_handler.dart

Issue 340783011: Take inheritance into account when computing the elements accessible by mirrors. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: rebased + fixes Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/js_backend/js_backend.dart ('k') | sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/js_backend/type_variable_handler.dart

diff --git a/sdk/lib/_internal/compiler/implementation/js_backend/type_variable_handler.dart b/sdk/lib/_internal/compiler/implementation/js_backend/type_variable_handler.dart

index 8f3a3786a4c6efa0b0e7a52082f1497ba4577804..c7443ac3c8f27e87c95877933a662d7c6934dc66 100644

--- a/sdk/lib/_internal/compiler/implementation/js_backend/type_variable_handler.dart

+++ b/sdk/lib/_internal/compiler/implementation/js_backend/type_variable_handler.dart

@@ -53,12 +53,12 @@ class TypeVariableHandler {

bool hasMemberNeededForReflection(ClassElement cls) {

bool result = false;

cls.implementation.forEachMember((ClassElement cls, Element member) {

- result = result || backend.isNeededForReflection(member);

+ result = result || backend.referencedFromMirrorSystem(member);

});

return result;

}

- if (!backend.isNeededForReflection(cls) &&

+ if (!backend.referencedFromMirrorSystem(cls) &&

!hasMemberNeededForReflection(cls)) {

return;

}