visibility bug fix for https://crbug.com/246844

ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h"
 
 #include <X11/extensions/shape.h>
 #include <X11/extensions/XInput2.h>
 #include <X11/Xatom.h>
 #include <X11/Xregion.h>
@@ skipping 1162 matching lines @@
     SetWindowIcons(gfx::ImageSkia(), *window_icon);
   }
   CreateCompositor(GetAcceleratedWidget());
 }
 
 void DesktopWindowTreeHostX11::OnWMStateUpdated() {
   std::vector< ::Atom> atom_list;
   if (!ui::GetAtomArrayProperty(xwindow_, "_NET_WM_STATE", &atom_list))
     return;
 
+  bool was_minimized = IsMinimized();
+
   window_properties_.clear();
   std::copy(atom_list.begin(), atom_list.end(),
             inserter(window_properties_, window_properties_.begin()));
 
+  // Propagate the window minimization information to the content window, so
+  // the render side can update its visibility properly. OnWMStateUpdated() is
+  // called by PropertyNofify event from DispatchEvent() when the browser is
+  // minimized or shown from minimized state. On Windows, this is realized by
+  // calling OnHostResized() with an empty size. In particular,
+  // HWNDMessageHandler::GetClientAreaBounds() returns an empty size when the
+  // window is minimized. On Linux, returning empty size in GetBounds() or
+  // SetBounds() does not work.
+  bool is_minimized = IsMinimized();
+  if (was_minimized == false && is_minimized == true) {
+    content_window_->Hide();
+  } else if (was_minimized == true && is_minimized == false) {
+    content_window_->Show();
+  }

[pkotwicz, 2014/06/19 22:50:36]

I think a structure like this would be slightly nicer?

if (is_minimized != was_minimized) {
  if (is_minimized)
    content_window_->Hide();
  else
    content_window_->Show();
}

[Zhen Wang, 2014/06/19 23:02:24]

Indeed. Updated.

On 2014/06/19 22:50:36, pkotwicz wrote:

+
   if (restored_bounds_.IsEmpty()) {
     DCHECK(!IsFullscreen());
     if (IsMaximized()) {
       // The request that we become maximized originated from a different
       // process. |bounds_| already contains our maximized bounds. Do a best
       // effort attempt to get restored bounds by setting it to our previously
       // set bounds (and if we get this wrong, we aren't any worse off since
       // we'd otherwise be returning our maximized bounds).
       restored_bounds_ = previous_bounds_;
     }
@@ skipping 590 matching lines @@
   if (linux_ui) {
     ui::NativeTheme* native_theme = linux_ui->GetNativeTheme(window);
     if (native_theme)
       return native_theme;
   }
 
   return ui::NativeTheme::instance();
 }
 
 }  // namespace views