visibility bug fix for https://crbug.com/246844

ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h"
 
 #include <X11/extensions/shape.h>
 #include <X11/extensions/XInput2.h>
 #include <X11/Xatom.h>
 #include <X11/Xregion.h>
@@ skipping 1162 matching lines @@
     SetWindowIcons(gfx::ImageSkia(), *window_icon);
   }
   CreateCompositor(GetAcceleratedWidget());
 }
 
 void DesktopWindowTreeHostX11::OnWMStateUpdated() {
   std::vector< ::Atom> atom_list;
   if (!ui::GetAtomArrayProperty(xwindow_, "_NET_WM_STATE", &atom_list))
     return;
 
+  bool was_minimized = IsMinimized();
+  bool is_minimized;
+
   window_properties_.clear();
   std::copy(atom_list.begin(), atom_list.end(),
             inserter(window_properties_, window_properties_.begin()));
 
+  // Propagate the window minimization information to the content window, so
+  // the render side can update its visibility properly. OnWMStateUpdated() is
+  // called by PropertyNofify event from DispatchEvent() when the browser is
+  // minimized or shown from minimized state.

[Elliot Glaysher, 2014/06/19 20:09:56]

If you go this route, please also mention that on Windows, this works by calling
OnHostResized() with an empty size. In particular,
HWNDMessageHandler::GetClientAreaBounds() returns an empty size when the window
is minimized.

If you instead just insert "if (IsMinimized()) return gfx::Rect();" into
DWTHX11::GetClientAreaBounds() like DWTHWin does, does visibility work?

(pkotwicz@ mentioned that DRWHWin::IsVisible() also returns true when minimized,
so the X11 equivalent here should be fine...)

[Zhen Wang, 2014/06/19 22:45:01]

This is just a note. I have discussed with Elliot and tried the Linux version of
returning empty size. It does not work. So for now, we will just use this way to
update visibility accordingly.

On 2014/06/19 20:09:56, Elliot Glaysher wrote:

+  is_minimized = IsMinimized();

[Elliot Glaysher, 2014/06/19 20:09:56]

Move the declaration of bool is_minimized here, since this is the first place
it's used.

+  if (was_minimized == false && is_minimized == true) {
+    content_window_->Hide();
+  } else if (was_minimized == true && is_minimized == false) {
+    content_window_->Show();
+  }
+
   if (restored_bounds_.IsEmpty()) {
     DCHECK(!IsFullscreen());
     if (IsMaximized()) {
       // The request that we become maximized originated from a different
       // process. |bounds_| already contains our maximized bounds. Do a best
       // effort attempt to get restored bounds by setting it to our previously
       // set bounds (and if we get this wrong, we aren't any worse off since
       // we'd otherwise be returning our maximized bounds).
       restored_bounds_ = previous_bounds_;
     }
@@ skipping 590 matching lines @@
   if (linux_ui) {
     ui::NativeTheme* native_theme = linux_ui->GetNativeTheme(window);
     if (native_theme)
       return native_theme;
   }
 
   return ui::NativeTheme::instance();
 }
 
 }  // namespace views