content/public/common/push_messaging_status.cc - Issue 340773006: Dispatch push event to worker from PushServiceImpl#OnMessage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/common/push_messaging_status.cc

Issue 340773006: Dispatch push event to worker from PushServiceImpl#OnMessage. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address John's comments. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/public/common/push_messaging_status.cc

diff --git a/content/public/common/push_messaging_status.cc b/content/public/common/push_messaging_status.cc

index 0040072bc0806e7ff883b298b2ca2a6ca8f894f3..f01cf80ca1fe4ef2f49ea17b6f45f25a5615c02a 100644

--- a/content/public/common/push_messaging_status.cc

+++ b/content/public/common/push_messaging_status.cc

@@ -28,6 +28,12 @@ const char* PushMessagingStatusToString(PushMessagingStatus status) {

case PUSH_MESSAGING_STATUS_REGISTRATION_FAILED_SERVICE_ERROR:

return "Registration failed - push service error";

+ case PUSH_MESSAGING_STATUS_MESSAGE_DELIVERY_FAILED_NO_SERVICE_WORKER:

+ return "Message delivery failed - no Service Worker";

+ case PUSH_MESSAGING_STATUS_MESSAGE_DELIVERY_FAILED_SERVICE_WORKER_ERROR:

+ return "Message delivery failed - Service Worker error";

case PUSH_MESSAGING_STATUS_ERROR:

return "Operation has failed (unspecified reason)";

}