Enable pointer warping with multiple displays under Ozone

Enable pointer warping with multiple displays under Ozone

Mouse events generated from Ozone do not have a NativeEvent associated
with them and so they need to go through the non native event based flow
in the multi-monitor warping code. With this change it is now possible
to move the pointer from one display to the next under Ozone.

TEST=On link_freon attach a second display and move the pointer from
one display to the other.
BUG=361144
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278406

[dnicoara, 2014-06-18 17:36:34]

I suppose this can be a temporary solution until the event refactoring work that
sadrul@ and kpschoedel@ are doing will be done (they are working on removing the
need for native events in places such as this).

Though I do not know for how long the old way of filtering events will be left.
oshima@ can comment on whether it is worth making this change or if the old path
is likely to be deleted soon.

[oshima, 2014-06-18 17:45:36]

On 2014/06/18 17:36:34, dnicoara wrote:
> I suppose this can be a temporary solution until the event refactoring work
that
> sadrul@ and kpschoedel@ are doing will be done (they are working on removing
the
> need for native events in places such as this).

Can you elaborate? I need a native event's coordinates in order to properly
handle mouse waring between display.

> 
> Though I do not know for how long the old way of filtering events will be
left.
> oshima@ can comment on whether it is worth making this change or if the old
path
> is likely to be deleted soon.

[dnicoara, 2014-06-18 17:47:13]

On 2014/06/18 17:45:36, oshima wrote:
> On 2014/06/18 17:36:34, dnicoara wrote:
> > I suppose this can be a temporary solution until the event refactoring work
> that
> > sadrul@ and kpschoedel@ are doing will be done (they are working on removing
> the
> > need for native events in places such as this).
> 
> Can you elaborate? I need a native event's coordinates in order to properly
> handle mouse waring between display.
> 

I think the plan is to provide the same functionality through ui::Events.

> > 
> > Though I do not know for how long the old way of filtering events will be
> left.
> > oshima@ can comment on whether it is worth making this change or if the old
> path
> > is likely to be deleted soon.

[dnicoara, 2014-06-18 17:49:44]

On 2014/06/18 17:47:13, dnicoara wrote:
> On 2014/06/18 17:45:36, oshima wrote:
> > On 2014/06/18 17:36:34, dnicoara wrote:
> > > I suppose this can be a temporary solution until the event refactoring
work
> > that
> > > sadrul@ and kpschoedel@ are doing will be done (they are working on
removing
> > the
> > > need for native events in places such as this).
> > 
> > Can you elaborate? I need a native event's coordinates in order to properly
> > handle mouse waring between display.
> > 
> 
> I think the plan is to provide the same functionality through ui::Events.
> 
> > > 
> > > Though I do not know for how long the old way of filtering events will be
> > left.
> > > oshima@ can comment on whether it is worth making this change or if the
old
> > path
> > > is likely to be deleted soon.

I also realized that I might have been a bit vague in my initial message. I'm
not sure for how long the old path guarded by
|enable_mouse_warp_in_native_coords| will be around. I'm assuming you'd like to
get rid of it asap.

[oshima, 2014-06-18 17:51:02]

On 2014/06/18 17:47:13, dnicoara wrote:
> On 2014/06/18 17:45:36, oshima wrote:
> > On 2014/06/18 17:36:34, dnicoara wrote:
> > > I suppose this can be a temporary solution until the event refactoring
work
> > that
> > > sadrul@ and kpschoedel@ are doing will be done (they are working on
removing
> > the
> > > need for native events in places such as this).
> > 
> > Can you elaborate? I need a native event's coordinates in order to properly
> > handle mouse waring between display.
> > 
> 
> I think the plan is to provide the same functionality through ui::Events.

Got it. do you have ETA? I was planning to remove this flag after coming branch
cut,
but looks like i need to keep it a bit more.
 
> > > 
> > > Though I do not know for how long the old way of filtering events will be
> > left.
> > > oshima@ can comment on whether it is worth making this change or if the
old
> > path
> > > is likely to be deleted soon.

[dnicoara, 2014-06-18 17:53:00]

+sadrul@

Not sure on the timeline. Sadrul can comment on that.

[sadrul, 2014-06-18 19:18:51]

On 2014/06/18 17:53:00, dnicoara wrote:
> +sadrul@
> 
> Not sure on the timeline. Sadrul can comment on that.

I expect it's still a couple of milestones away.

[oshima, 2014-06-18 19:23:10]

On 2014/06/18 19:18:51, sadrul wrote:
> On 2014/06/18 17:53:00, dnicoara wrote:
> > +sadrul@
> > 
> > Not sure on the timeline. Sadrul can comment on that.
> 
> I expect it's still a couple of milestones away.

Ok, sounds like I need to keep it around for a while. lgtm

[robert.bradford, 2014-06-19 11:16:37]

The CQ bit was checked by robert.bradford@intel.com

[commit-bot: I haz the power, 2014-06-19 11:18:18]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/robert.bradford@intel.com/340773003/1

[commit-bot: I haz the power, 2014-06-19 16:53:36]

Change committed as 278406

[oshima, 2014-06-19 17:01:19]

On 2014/06/19 16:53:36, I haz the power (commit-bot) wrote:
> Change committed as 278406

just FYI: after 37 branch cut, I'll move this code to _ozone.cc.