Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 340763004: [Android] Set the PowerSaveBlocker's View to have zero dimensions (Closed)

Created:
6 years, 6 months ago by mnaganov (inactive)
Modified:
6 years, 6 months ago
Reviewers:
bulach, benm (inactive)
CC:
chromium-reviews, android-webview-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

[Android] Set the PowerSaveBlocker's View to have zero dimensions Currently the View created by PowerSaveBlocker has the same size as the parent view. This is not acceptable at least for WebView applications, since such a View can interfere with application logic in case when the application maintains its own child Views for WebView. The view must be visible (otherwise, KeepScreenOn has no effect), but we can set it to have zero dimensions, thus minimizing interference. BUG=270903, 386087 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278505

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ui/android/java/src/org/chromium/ui/base/ViewAndroid.java View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
mnaganov (inactive)
6 years, 6 months ago (2014-06-18 11:11:17 UTC) #1
mnaganov (inactive)
Ben, ping? It's just one line.
6 years, 6 months ago (2014-06-19 07:24:51 UTC) #2
benm (inactive)
lgtm
6 years, 6 months ago (2014-06-19 09:23:58 UTC) #3
benm (inactive)
6 years, 6 months ago (2014-06-19 09:23:59 UTC) #4
mnaganov (inactive)
Hi Marcus, would you mind doing an OWNER's review?
6 years, 6 months ago (2014-06-19 09:32:42 UTC) #5
bulach
lgtm, thanks!
6 years, 6 months ago (2014-06-19 16:46:10 UTC) #6
mnaganov (inactive)
The CQ bit was checked by mnaganov@chromium.org
6 years, 6 months ago (2014-06-19 16:48:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mnaganov@chromium.org/340763004/1
6 years, 6 months ago (2014-06-19 16:54:46 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 22:16:18 UTC) #9
Message was sent while issue was closed.
Change committed as 278505

Powered by Google App Engine
This is Rietveld 408576698