Source/bindings/tests/results/V8TestInterfaceConstructor.cpp - Issue 340763003: Change [ConstructorCallWith={Document => ExecutionContext}]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/V8TestInterfaceConstructor.cpp

Issue 340763003: Change [ConstructorCallWith={Document => ExecutionContext}] (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/tests/idls/TestInterfaceNamedConstructor.idl ('k') | Source/bindings/tests/results/V8TestInterfaceEventTarget.cpp » ('j') | Source/core/dom/Document.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/V8TestInterfaceConstructor.cpp

diff --git a/Source/bindings/tests/results/V8TestInterfaceConstructor.cpp b/Source/bindings/tests/results/V8TestInterfaceConstructor.cpp

index 5be99ad997ff607fb5398c933e8db97d9bbab7e4..1297c55d256c9d82bf492e6ce99cc1dd8dcee41e 100644

--- a/Source/bindings/tests/results/V8TestInterfaceConstructor.cpp

+++ b/Source/bindings/tests/results/V8TestInterfaceConstructor.cpp

@@ -51,8 +51,7 @@ static void constructor1(const v8::FunctionCallbackInfo<v8::Value>& info)

v8::Isolate* isolate = info.GetIsolate();

ExceptionState exceptionState(ExceptionState::ConstructionContext, "TestInterfaceConstructor", info.Holder(), isolate);

ExecutionContext* executionContext = currentExecutionContext(isolate);

- Document& document = *toDocument(currentExecutionContext(isolate));

- RefPtr<TestInterfaceConstructor> impl = TestInterfaceConstructor::create(executionContext, document, exceptionState);

+ RefPtr<TestInterfaceConstructor> impl = TestInterfaceConstructor::create(executionContext, exceptionState);

if (exceptionState.throwIfNeeded())

return;

@@ -96,8 +95,7 @@ static void constructor2(const v8::FunctionCallbackInfo<v8::Value>& info)

TONATIVE_VOID_INTERNAL(optionalTestInterfaceEmptyArg, V8TestInterfaceEmpty::toNativeWithTypeCheck(info.GetIsolate(), info[7]));

}

ExecutionContext* executionContext = currentExecutionContext(isolate);

- Document& document = *toDocument(currentExecutionContext(isolate));

- RefPtr<TestInterfaceConstructor> impl = TestInterfaceConstructor::create(executionContext, document, doubleArg, stringArg, testInterfaceEmptyArg, dictionaryArg, sequenceStringArg, sequenceDictionaryArg, optionalDictionaryArg, optionalTestInterfaceEmptyArg, exceptionState);

+ RefPtr<TestInterfaceConstructor> impl = TestInterfaceConstructor::create(executionContext, doubleArg, stringArg, testInterfaceEmptyArg, dictionaryArg, sequenceStringArg, sequenceDictionaryArg, optionalDictionaryArg, optionalTestInterfaceEmptyArg, exceptionState);

if (exceptionState.throwIfNeeded())

return;