Source/bindings/tests/results/V8TestInterfaceNamedConstructor2.cpp - Issue 340763003: Change [ConstructorCallWith={Document => ExecutionContext}]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/V8TestInterfaceNamedConstructor2.cpp

Issue 340763003: Change [ConstructorCallWith={Document => ExecutionContext}] (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/templates/methods.cpp ('K') | « Source/bindings/tests/results/V8TestInterfaceNamedConstructor.cpp ('k') | Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.cpp » ('j') | Source/core/dom/Comment.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/V8TestInterfaceNamedConstructor2.cpp

diff --git a/Source/bindings/tests/results/V8TestInterfaceNamedConstructor2.cpp b/Source/bindings/tests/results/V8TestInterfaceNamedConstructor2.cpp

index ea7a9a97842fd847263fcf45f8c8e70a36d4a52e..d58e829bb8ec5e55674d76d79eba460305e5153f 100644

--- a/Source/bindings/tests/results/V8TestInterfaceNamedConstructor2.cpp

+++ b/Source/bindings/tests/results/V8TestInterfaceNamedConstructor2.cpp

@@ -60,9 +60,10 @@ static void V8TestInterfaceNamedConstructor2ConstructorCallback(const v8::Functi

return;

}

- Document* documentPtr = currentDOMWindow(isolate)->document();

+ ExecutionContext* executionContext = currentExecutionContext(info.GetIsolate());

+ Document* documentPtr = toDocument(executionContext);

ASSERT(documentPtr);

- Document& document = *documentPtr;

// Make sure the document is added to the DOM Node map. Otherwise, the TestInterfaceNamedConstructor2 instance

// may end up being the only node in the map and get garbage-collected prematurely.