Change [ConstructorCallWith={Document => ExecutionContext}]

Source/core/dom/Document.h

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  *           (C) 2006 Alexey Proskuryakov (ap@webkit.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
@@ skipping 227 matching lines @@
 class Document : public ContainerNode, public TreeScope, public SecurityContext, public ExecutionContext, public ExecutionContextClient
     , public DocumentSupplementable, public LifecycleContext<Document> {
     WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(Document);
 public:
     static PassRefPtrWillBeRawPtr<Document> create(const DocumentInit& initializer = DocumentInit())
     {
         return adoptRefWillBeNoop(new Document(initializer));
     }
     virtual ~Document();
 
+    operator ExecutionContext*() { return this; }

[Jens Widell, 2014/06/18 12:53:29]

Operator added primarily to make authoring this patch quicker.

If we don't like it, I'll go through all the calls that now depend on it make
the simple changes necessary.

Didn't want to do all that first, in case the response had been "add a
conversion operator to Document" instead. :-)

[haraken, 2014/06/18 13:15:01]

I think we want to avoid implicit conversions as much as possible, since
implicit conversions can easily lead to unexpected conversions.
How hard would it be to replace all the calls? If it's hard, I'm OK with adding
a FIXME here and remove the implicit conversion in follow-up CLs.

[Jens Widell, 2014/06/18 14:19:43]

I don't disagree. OTOH, there's a public inheritance relationship in play here.
Implicit conversion is quite expected then, and we'd have had it already had it
not been for the fact that we tend to use Document& and ExecutionContext*.
Technically trivial.

It's mostly a matter of changing "create(document(), ...)" into
"create(&document(), ...)". But I think that's a somewhat sad thing to do,
adding "&" doesn't really make the code better in any way, we still have an
implicit conversion, and taking the address of a function return value is sort
of... iffy.

We could of course also make that "toExecutionContext(document())" or
"document().asExecutionContext()" or something, with added utility functions (or
maybe there's something like that already?)

[tkent, 2014/06/18 23:44:24]

Changing Document arguments of factory functions to ExecutionContext looks a
regression to me.  DOM Node factories really need Documents, not
ExecutionContexts.  So the arguments should be Documents.

This CL is harmful for non-binding C++ code.

+
     MediaQueryMatcher& mediaQueryMatcher();
 
     void mediaQueryAffectingValueChanged();
 
 #if !ENABLE(OILPAN)
     using ContainerNode::ref;
     using ContainerNode::deref;
 #endif
     using SecurityContext::securityOrigin;
     using SecurityContext::contentSecurityPolicy;
@@ skipping 1208 matching lines @@
 inline bool Node::isDocumentNode() const
 {
     return this == document();
 }
 
 Node* eventTargetNodeForDocument(Document*);
 
 } // namespace WebCore
 
 #endif // Document_h