Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 340733002: Disable WebSocket_UtilityBufferedAmount browser test. (Closed)

Created:
6 years, 6 months ago by yhirano
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Disable WebSocket_UtilityBufferedAmount browser test. The test has passed accidentaly with the new implementation and now fails with the bufferedAmount change. The root causes of the failure is not the change and it takes some time to fix. Hence this CL tentatively disables the test. It should be re-enabled in the near future. BUG=159563 R=tyoshino@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278112

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/test/ppapi/ppapi_browsertest.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
yhirano
6 years, 6 months ago (2014-06-18 05:48:45 UTC) #1
tyoshino (SeeGerritForStatus)
lgtm
6 years, 6 months ago (2014-06-18 09:30:47 UTC) #2
yhirano
+bbudge@ for OWNER review.
6 years, 6 months ago (2014-06-18 12:03:28 UTC) #3
bbudge-google
lgtm
6 years, 6 months ago (2014-06-18 12:10:09 UTC) #4
yhirano
The CQ bit was checked by yhirano@chromium.org
6 years, 6 months ago (2014-06-18 12:11:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yhirano@chromium.org/340733002/1
6 years, 6 months ago (2014-06-18 12:12:47 UTC) #6
yhirano
On 2014/06/18 12:10:09, bbudge-google wrote: > lgtm Can you give me l-g-t-m from bbudge@chromium.org?
6 years, 6 months ago (2014-06-18 12:48:33 UTC) #7
bbudge
lgtm
6 years, 6 months ago (2014-06-18 13:01:34 UTC) #8
chromium-reviews
whoops -Bill On Wed, Jun 18, 2014 at 5:48 AM, <yhirano@chromium.org> wrote: > On 2014/06/18 ...
6 years, 6 months ago (2014-06-18 13:01:57 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-18 16:55:07 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/18673)
6 years, 6 months ago (2014-06-18 16:55:07 UTC) #11
yhirano
The CQ bit was checked by yhirano@chromium.org
6 years, 6 months ago (2014-06-18 17:06:53 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yhirano@chromium.org/340733002/1
6 years, 6 months ago (2014-06-18 17:07:35 UTC) #13
commit-bot: I haz the power
6 years, 6 months ago (2014-06-18 17:27:48 UTC) #14
Message was sent while issue was closed.
Change committed as 278112

Powered by Google App Engine
This is Rietveld 408576698